Sign upLogin

aeolusproject/conductor

View on GitHub
Star
src/app/controllers/providers_controller.rb

Summary

Maintainability
D
2 days
Test Coverage

File providers_controller.rb has 406 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class ProvidersController < ApplicationController
  before_filter :require_user
  before_filter :load_providers, :only => [:index, :show, :new, :edit, :create, :update]
  before_filter :load_providers_types, :only => [:new, :edit, :update, :create]
  before_filter ResourceLinkFilter.new({ :provider => :provider_type }),
Severity: Minor
Found in src/app/controllers/providers_controller.rb - About 5 hrs to fix

    Method statistics has 109 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def statistics
    @statistics = Hash.new
    @providers.each do |provider|
      @statistics[provider.id] = {
        "running_instances" => 0,
    Severity: Major
    Found in src/app/controllers/providers_controller.rb - About 4 hrs to fix

      Method statistics has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

        def statistics
    @statistics = Hash.new
    @providers.each do |provider|
      @statistics[provider.id] = {
        "running_instances" => 0,
      Severity: Minor
      Found in src/app/controllers/providers_controller.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method update has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def update
    @provider = Provider.find(params[:id])
    require_privilege(Alberich::Privilege::MODIFY, @provider)

    @provider.assign_attributes(params[:provider])
      Severity: Minor
      Found in src/app/controllers/providers_controller.rb - About 1 hr to fix

        Method create has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def create
    @title = _('New Provider')
    require_privilege(Alberich::Privilege::CREATE, Provider)
    @provider = Provider.new(params[:provider])
        Severity: Minor
        Found in src/app/controllers/providers_controller.rb - About 1 hr to fix

          Method load_provider_tabs has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def load_provider_tabs
    @realms = @provider.provider_realms.apply_filters(:preset_filter_id => params[:provider_realms_preset_filter], :search_filter => params[:provider_realms_search])
    #TODO add links to real data for history,properties,permissions
    @tabs = [{ :name => _('Properties'),
               :view => 'properties',
          Severity: Minor
          Found in src/app/controllers/providers_controller.rb - About 1 hr to fix

            Method provider_alerts has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def provider_alerts(provider)
    alerts = []

    # Quota Alerts
    provider.provider_accounts.each do |provider_account|
            Severity: Minor
            Found in src/app/controllers/providers_controller.rb - About 1 hr to fix

              Method provider_alerts has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                def provider_alerts(provider)
    alerts = []

    # Quota Alerts
    provider.provider_accounts.each do |provider_account|
              Severity: Minor
              Found in src/app/controllers/providers_controller.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method load_provider_tabs has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                def load_provider_tabs
    @realms = @provider.provider_realms.apply_filters(:preset_filter_id => params[:provider_realms_preset_filter], :search_filter => params[:provider_realms_search])
    #TODO add links to real data for history,properties,permissions
    @tabs = [{ :name => _('Properties'),
               :view => 'properties',
              Severity: Minor
              Found in src/app/controllers/providers_controller.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method update has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                def update
    @provider = Provider.find(params[:id])
    require_privilege(Alberich::Privilege::MODIFY, @provider)

    @provider.assign_attributes(params[:provider])
              Severity: Minor
              Found in src/app/controllers/providers_controller.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  @from_date = params[:from_date].nil? ? Date.today - 7.days :
      Date.civil(params[:from_date][:year].to_i,
                 params[:from_date][:month].to_i,
                 params[:from_date][:day].to_i)
    @to_date = params[:to_date].nil? ? Date.today :
              Severity: Minor
              Found in src/app/controllers/providers_controller.rb and 1 other location - About 25 mins to fix
              src/app/controllers/logs_controller.rb on lines 98..102

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 31.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  @to_date = params[:to_date].nil? ? Date.today :
      Date.civil(params[:to_date][:year].to_i,
                 params[:to_date][:month].to_i,
                 params[:to_date][:day].to_i)
              Severity: Minor
              Found in src/app/controllers/providers_controller.rb and 1 other location - About 20 mins to fix
              src/app/controllers/logs_controller.rb on lines 102..107

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 28.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status