Sign upLogin

aeolusproject/conductor

View on GitHub
Star
src/app/models/provider_account.rb

Summary

Maintainability
C
1 day
Test Coverage

Class ProviderAccount has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

class ProviderAccount < ActiveRecord::Base

  class << self
    include CommonFilterMethods
  end
Severity: Minor
Found in src/app/models/provider_account.rb - About 3 hrs to fix

    File provider_account.rb has 292 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class ProviderAccount < ActiveRecord::Base

  class << self
    include CommonFilterMethods
  end
    Severity: Minor
    Found in src/app/models/provider_account.rb - About 3 hrs to fix

      Method credentials_hash= has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

        def credentials_hash=(hash={})
    if provider
      cred_defs = provider.provider_type.credential_definitions
      hash.each do |k,v|
        cred_def = cred_defs.detect {|d| d.name == k.to_s}
      Severity: Minor
      Found in src/app/models/provider_account.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method to_xml has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def to_xml(options = {})
    with_credentials = options[:with_credentials] || false

    doc = Nokogiri::XML('')
    doc.root = Nokogiri::XML::Node.new('provider_account', doc)
      Severity: Minor
      Found in src/app/models/provider_account.rb - About 1 hr to fix

        Method check_destroyable_instances! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def check_destroyable_instances!
    not_destroyable_instances = instances.find_all {|i| !i.destroyable?}
    if not_destroyable_instances.empty?
      true
    else
        Severity: Minor
        Found in src/app/models/provider_account.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status