Sign upLogin

aeolusproject/conductor

View on GitHub
Star
src/app/models/task.rb

Summary

Maintainability
A
35 mins
Test Coverage

Method validate_task has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def validate_task
    errors.add("created_at", "Task started but does not have the creation time set") if time_started and created_at.nil?
    # Removed check on time_started exisiting. if time_ended does.  This can now occur, when the task fails before is starts.  e.g. When Over Qutoa
    #errors.add("time_started", "Task ends but does not have the start time set") if time_ended and time_started.nil?
    errors.add("time_ended", "Tasks ends before it's started") unless time_ended.nil? or time_started.nil? or time_ended >= time_started
Severity: Minor
Found in src/app/models/task.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status