Sign upLogin

aeolusproject/conductor

View on GitHub
Star
src/app/util/deployable_xml.rb

Summary

Maintainability
B
5 hrs
Test Coverage

File deployable_xml.rb has 267 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'tsort'

class ValidationError < RuntimeError; end

class ParameterXML
Severity: Minor
Found in src/app/util/deployable_xml.rb - About 2 hrs to fix

    Method not_existing_references has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

      def not_existing_references
    # not_existing references are detected when doing tsort
    strongly_connected_components

    invalid_refs = []
    Severity: Minor
    Found in src/app/util/deployable_xml.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def initialize(name, description, executable, files, parameters)
    Severity: Minor
    Found in src/app/util/deployable_xml.rb - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status