Sign upLogin

aeolusproject/conductor

View on GitHub
Star
src/app/util/taskomatic.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method create_instance! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def self.create_instance!(task, match, config_server, config)
    begin
      task.state = Task::STATE_PENDING
      task.save!
Severity: Minor
Found in src/app/util/taskomatic.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method do_action has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def self.do_action(task, action)
    task.time_started = Time.now

    begin
      client = task.instance.provider_account.connect
Severity: Minor
Found in src/app/util/taskomatic.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_dcloud_instance has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def self.create_dcloud_instance(instance, match)
    client = match.provider_account.connect
    raise _('Could not connect to Provider Account.  Please contact an Administrator.') unless client

    client_args = {
Severity: Minor
Found in src/app/util/taskomatic.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      return Instance::STATE_SHUTTING_DOWN
Severity: Major
Found in src/app/util/taskomatic.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return Instance::STATE_PENDING
    Severity: Major
    Found in src/app/util/taskomatic.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return Instance::STATE_SHUTTING_DOWN
      Severity: Major
      Found in src/app/util/taskomatic.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status