Sign upLogin

aergoio/aergo

View on GitHub
Star
account/accountservice.go

Summary

Maintainability
C
1 day
Test Coverage
F
24%

Method AccountService.Receive has 75 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (as *AccountService) Receive(context actor.Context) {

    switch msg := context.Message().(type) {
    case *message.GetAccounts:
        accountList := as.getAccounts()
Severity: Minor
Found in account/accountservice.go - About 2 hrs to fix

    Method AccountService.Receive has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
    Open

    func (as *AccountService) Receive(context actor.Context) {

    switch msg := context.Message().(type) {
    case *message.GetAccounts:
        accountList := as.getAccounts()
    Severity: Minor
    Found in account/accountservice.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        case *message.UnlockAccount:
        actualAddress := msg.Account.Address
        var err error
        if len(actualAddress) == types.NameLength {
            actualAddress, err = as.resolveName(actualAddress)
    Severity: Major
    Found in account/accountservice.go and 1 other location - About 1 hr to fix
    account/accountservice.go on lines 83..96

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 167.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        case *message.LockAccount:
        actualAddress := msg.Account.Address
        var err error
        if len(actualAddress) == types.NameLength {
            actualAddress, err = as.resolveName(actualAddress)
    Severity: Major
    Found in account/accountservice.go and 1 other location - About 1 hr to fix
    account/accountservice.go on lines 97..110

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 167.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (as *AccountService) unlockAccount(address []byte, passphrase string) (*types.Account, error) {
    addr, err := as.ks.Unlock(address, passphrase)
    if err != nil {
        as.Warn().Err(err).Msg("could not find the key")
        return nil, err
    Severity: Minor
    Found in account/accountservice.go and 1 other location - About 55 mins to fix
    account/accountservice.go on lines 228..235

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 124.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (as *AccountService) lockAccount(address []byte, passphrase string) (*types.Account, error) {
    addr, err := as.ks.Lock(address, passphrase)
    if err != nil {
        as.Warn().Err(err).Msg("could not load the key")
        return nil, err
    Severity: Minor
    Found in account/accountservice.go and 1 other location - About 55 mins to fix
    account/accountservice.go on lines 219..226

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 124.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status