Sign upLogin

aergoio/aergo

View on GitHub
Star
chain/signVerifier.go

Summary

Maintainability
A
2 hrs
Test Coverage
F
56%

Method SignVerifier.RequestVerifyTxs has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
Open

func (sv *SignVerifier) RequestVerifyTxs(txlist *types.TxList) {
    txs := txlist.GetTxs()
    txLen := len(txs)

    if txLen == 0 {
Severity: Minor
Found in chain/signVerifier.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method SignVerifier.verifyTx has 7 return statements (exceeds 4 allowed).
Open

func (sv *SignVerifier) verifyTx(comm component.IComponentRequester, tx *types.Tx, useMempool bool) (hit bool, err error) {
    account := tx.GetBody().GetAccount()
    if account == nil {
        return false, ErrTxFormatInvalid
    }
Severity: Major
Found in chain/signVerifier.go - About 45 mins to fix

    Method SignVerifier.isExistInMempool has 5 return statements (exceeds 4 allowed).
    Open

    func (sv *SignVerifier) isExistInMempool(comm component.IComponentRequester, tx *types.Tx) (bool, error) {
    if !sv.useMempool {
        return false, nil
    }
    Severity: Major
    Found in chain/signVerifier.go - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status