Sign upLogin

aergoio/aergo

View on GitHub
Star
consensus/impl/raftv2/raftserver.go

Summary

Maintainability
F
5 days
Test Coverage
F
0%

File raftserver.go has 1151 lines of code (exceeds 500 allowed). Consider refactoring.
Open

// Copyright 2015 The etcd Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
Severity: Major
Found in consensus/impl/raftv2/raftserver.go - About 2 days to fix

    raftServer has 53 methods (exceeds 20 allowed). Consider refactoring.
    Open

    type raftServer struct {
    *component.ComponentHub
    sync.RWMutex

    pa p2pcommon.PeerAccessor
    Severity: Major
    Found in consensus/impl/raftv2/raftserver.go - About 7 hrs to fix

      Method raftServer.serveChannels has a Cognitive Complexity of 55 (exceeds 20 allowed). Consider refactoring.
      Open

      func (rs *raftServer) serveChannels() {
    defer RecoverExit()

    snapshot, err := rs.raftStorage.Snapshot()
    if err != nil {
      Severity: Minor
      Found in consensus/impl/raftv2/raftserver.go - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method raftServer.publishEntries has a Cognitive Complexity of 33 (exceeds 20 allowed). Consider refactoring.
      Open

      func (rs *raftServer) publishEntries(ents []raftpb.Entry) bool {
    var lastBlockEnt *raftpb.Entry

    isDuplicateCommit := func(block *types.Block) bool {
        lastReq := rs.commitProgress.GetRequest()
      Severity: Minor
      Found in consensus/impl/raftv2/raftserver.go - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method raftServer.startRaft has a Cognitive Complexity of 33 (exceeds 20 allowed). Consider refactoring.
      Open

      func (rs *raftServer) startRaft() {
    var node raftlib.Node

    getState := func() RaftServerState {
        hasWal, err := rs.walDB.HasWal(rs.cluster.identity)
      Severity: Minor
      Found in consensus/impl/raftv2/raftserver.go - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method raftServer.startRaft has 79 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (rs *raftServer) startRaft() {
    var node raftlib.Node

    getState := func() RaftServerState {
        hasWal, err := rs.walDB.HasWal(rs.cluster.identity)
      Severity: Major
      Found in consensus/impl/raftv2/raftserver.go - About 2 hrs to fix

        Method raftServer.serveChannels has 68 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (rs *raftServer) serveChannels() {
    defer RecoverExit()

    snapshot, err := rs.raftStorage.Snapshot()
    if err != nil {
        Severity: Minor
        Found in consensus/impl/raftv2/raftserver.go - About 1 hr to fix

          Method raftServer.GetClusterProgress has 7 return statements (exceeds 4 allowed).
          Open

          func (rs *raftServer) GetClusterProgress() (*ClusterProgress, error) {
    getProgressState := func(raftProgress *raftlib.Progress, lastLeaderIndex uint64, nodeID uint64, leadID uint64) MemberProgressState {
        isLeader := nodeID == leadID

        if !isLeader {
          Severity: Major
          Found in consensus/impl/raftv2/raftserver.go - About 45 mins to fix

            Method raftServer.publishSnapshot has 6 return statements (exceeds 4 allowed).
            Open

            func (rs *raftServer) publishSnapshot(snapshotToSave raftpb.Snapshot) error {
    updateProgress := func() error {
        var snapdata = &consensus.SnapshotData{}

        err := snapdata.Decode(snapshotToSave.Data)
            Severity: Major
            Found in consensus/impl/raftv2/raftserver.go - About 40 mins to fix

              Method raftServer.publishEntries has 5 return statements (exceeds 4 allowed).
              Open

              func (rs *raftServer) publishEntries(ents []raftpb.Entry) bool {
    var lastBlockEnt *raftpb.Entry

    isDuplicateCommit := func(block *types.Block) bool {
        lastReq := rs.commitProgress.GetRequest()
              Severity: Major
              Found in consensus/impl/raftv2/raftserver.go - About 35 mins to fix

                Method raftServer.triggerSnapshot has 5 return statements (exceeds 4 allowed).
                Open

                func (rs *raftServer) triggerSnapshot() {
    ce := rs.commitProgress.GetConnect()
    newSnapshotIndex, snapBlock := ce.index, ce.block

    if newSnapshotIndex == 0 || rs.confState == nil {
                Severity: Major
                Found in consensus/impl/raftv2/raftserver.go - About 35 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func (cp *CommitProgress) UpdateConnect(ce *commitEntry) {
    logger.Debug().Uint64("term", ce.term).Uint64("index", ce.index).Uint64("no", ce.block.BlockNo()).Str("hash", ce.block.ID()).Msg("set progress of last connected block")

    cp.Lock()
    defer cp.Unlock()
                  Severity: Major
                  Found in consensus/impl/raftv2/raftserver.go and 1 other location - About 1 hr to fix
                  consensus/impl/raftv2/raftserver.go on lines 157..164

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 138.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func (cp *CommitProgress) UpdateRequest(ce *commitEntry) {
    logger.Debug().Uint64("term", ce.term).Uint64("index", ce.index).Uint64("no", ce.block.BlockNo()).Str("hash", ce.block.ID()).Msg("set progress of last request block")

    cp.Lock()
    defer cp.Unlock()
                  Severity: Major
                  Found in consensus/impl/raftv2/raftserver.go and 1 other location - About 1 hr to fix
                  consensus/impl/raftv2/raftserver.go on lines 148..155

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 138.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  var (
    ErrRaftNotReady        = errors.New("raft library is not initialized")
    ErrCCAlreadyApplied    = errors.New("conf change entry is already applied")
    ErrInvalidMember       = errors.New("member of conf change is invalid")
    ErrCCAlreadyAdded      = errors.New("member has already added")
                  Severity: Minor
                  Found in consensus/impl/raftv2/raftserver.go and 1 other location - About 50 mins to fix
                  types/message/p2pmsg.go on lines 18..28

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 118.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status