Sign upLogin

aergoio/aergo

View on GitHub
Star
contract/ethstorageproof.go

Summary

Maintainability
A
3 hrs
Test Coverage
D
68%

Function verifyEthStorageProof has a Cognitive Complexity of 32 (exceeds 20 allowed). Consider refactoring.
Open

func verifyEthStorageProof(key []byte, value rlpObject, expectedHash []byte, proof [][]byte) bool {
    if len(key) == 0 || value == nil || len(proof) == 0 {
        return false
    }
    key = []byte(hex.Encode(keccak256(key)))
Severity: Minor
Found in contract/ethstorageproof.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function verifyEthStorageProof has 10 return statements (exceeds 4 allowed).
Open

func verifyEthStorageProof(key []byte, value rlpObject, expectedHash []byte, proof [][]byte) bool {
    if len(key) == 0 || value == nil || len(proof) == 0 {
        return false
    }
    key = []byte(hex.Encode(keccak256(key)))
Severity: Major
Found in contract/ethstorageproof.go - About 1 hr to fix

    Function decodeRlpTrieNode has 5 return statements (exceeds 4 allowed).
    Open

    func decodeRlpTrieNode(data []byte) rlpNode {
    var (
        dataLen = uint64(len(data))
        node    rlpNode
    )
    Severity: Major
    Found in contract/ethstorageproof.go - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status