Sign upLogin

aergoio/aergo

View on GitHub
Star
contract/name/execute.go

Summary

Maintainability
B
4 hrs
Test Coverage
C
79%

Function ExecuteNameTx has 64 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func ExecuteNameTx(bs *state.BlockState, scs *statedb.ContractState, txBody *types.TxBody,
    sender, receiver *state.AccountState, blockInfo *types.BlockHeaderInfo) ([]*types.Event, error) {

    ci, err := ValidateNameTx(txBody, sender, scs)
    if err != nil {
Severity: Minor
Found in contract/name/execute.go - About 1 hr to fix

    Function ValidateNameTx has 8 return statements (exceeds 4 allowed).
    Open

    func ValidateNameTx(tx *types.TxBody, sender *state.AccountState, scs *statedb.ContractState) (*types.CallInfo, error) {
    if sender != nil && sender.Balance().Cmp(tx.GetAmountBigInt()) < 0 {
        return nil, types.ErrInsufficientBalance
    }
    Severity: Major
    Found in contract/name/execute.go - About 50 mins to fix

      Function ExecuteNameTx has 6 return statements (exceeds 4 allowed).
      Open

      func ExecuteNameTx(bs *state.BlockState, scs *statedb.ContractState, txBody *types.TxBody,
    sender, receiver *state.AccountState, blockInfo *types.BlockHeaderInfo) ([]*types.Event, error) {

    ci, err := ValidateNameTx(txBody, sender, scs)
    if err != nil {
      Severity: Major
      Found in contract/name/execute.go - About 40 mins to fix

        Function SetContractOwner has 5 return statements (exceeds 4 allowed).
        Open

        func SetContractOwner(bs *state.BlockState, scs *statedb.ContractState,
    address string, nameState *state.AccountState) (*state.AccountState, error) {

    rawaddr, err := types.DecodeAddress(address)
    if err != nil {
        Severity: Major
        Found in contract/name/execute.go - About 35 mins to fix

          Function ExecuteNameTx has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
          Open

          func ExecuteNameTx(bs *state.BlockState, scs *statedb.ContractState, txBody *types.TxBody,
    sender, receiver *state.AccountState, blockInfo *types.BlockHeaderInfo) ([]*types.Event, error) {

    ci, err := ValidateNameTx(txBody, sender, scs)
    if err != nil {
          Severity: Minor
          Found in contract/name/execute.go - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status