Sign upLogin

aergoio/aergo

View on GitHub
Star
contract/system/vote.go

Summary

Maintainability
C
7 hrs
Test Coverage
C
72%

Function refreshAllVote has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
Open

func refreshAllVote(context *SystemContext) error {
    var (
        scs          = context.scs
        account      = context.Sender.ID()
        staked       = context.Staked
Severity: Minor
Found in contract/system/vote.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function refreshAllVote has 8 return statements (exceeds 4 allowed).
Open

func refreshAllVote(context *SystemContext) error {
    var (
        scs          = context.scs
        account      = context.Sender.ID()
        staked       = context.Staked
Severity: Major
Found in contract/system/vote.go - About 50 mins to fix

    Function newVprCmd has 5 return statements (exceeds 4 allowed).
    Open

    func newVprCmd(ctx *SystemContext, vr *VoteResult) *vprCmd {
    cmd := &vprCmd{SystemContext: ctx, voteResult: vr}

    if vprLogger.IsDebugEnabled() {
        vprLogger.Debug().
    Severity: Major
    Found in contract/system/vote.go - About 35 mins to fix

      Function newVoteCmd has 5 return statements (exceeds 4 allowed).
      Open

      func newVoteCmd(ctx *SystemContext) (sysCmd, error) {
    var (
        scs = ctx.scs

        err error
      Severity: Major
      Found in contract/system/vote.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (c *vprCmd) subVpr(v *types.Vote) {
    no := c.BlockInfo.No
    aid := c.Sender.AccountID()

    // Handle exception 1. multisig contract ( AmhNcvE7RR84xoRzYNyATnwZR2JXaC5ut7neu89R13aj1b4eUxKp )
        Severity: Major
        Found in contract/system/vote.go and 1 other location - About 2 hrs to fix
        contract/system/vote.go on lines 113..134

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 213.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (c *vprCmd) addVpr(v *types.Vote) {
    no := c.BlockInfo.No
    aid := c.Sender.AccountID()

    // Handle exception 1. multisig contract ( AmhNcvE7RR84xoRzYNyATnwZR2JXaC5ut7neu89R13aj1b4eUxKp )
        Severity: Major
        Found in contract/system/vote.go and 1 other location - About 2 hrs to fix
        contract/system/vote.go on lines 90..111

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 213.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status