Sign upLogin

aergoio/aergo

View on GitHub
Star
contract/system/vprt.go

Summary

Maintainability
C
1 day
Test Coverage
C
76%

File vprt.go has 587 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package system

import (
    "bytes"
    "container/list"
Severity: Minor
Found in contract/system/vprt.go - About 4 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                        if vprLogger.IsDebugEnabled() {
                        vprLogger.Debug().
                            Str("total voting power", totalVp.String()).
                            Str("addr", base58.Encode(winner)).
                            Msg("pick voting reward winner")
    Severity: Major
    Found in contract/system/vprt.go - About 45 mins to fix

      Method topVoters.dump has 5 return statements (exceeds 4 allowed).
      Open

      func (tv *topVoters) dump(w io.Writer, topN int) error {
    if tv == nil {
        fmt.Fprintf(w, "nothing to dump!")
        return nil
    }
      Severity: Major
      Found in contract/system/vprt.go - About 35 mins to fix

        Method vpr.equals has 5 return statements (exceeds 4 allowed).
        Open

        func (v *vpr) equals(rhs *vpr) bool {
    if !reflect.DeepEqual(v.getTotalPower(), rhs.getTotalPower()) {
        return false
    }
        Severity: Major
        Found in contract/system/vprt.go - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              v.prepare(id, addr,
        func(lhs *big.Int) {
            if vprLogger.IsDebugEnabled() {
                vprLogger.Debug().
                    Str("op", "add").
          Severity: Minor
          Found in contract/system/vprt.go and 1 other location - About 1 hr to fix
          contract/system/vprt.go on lines 629..641

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 129.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              v.prepare(id, addr,
        func(lhs *big.Int) {
            if vprLogger.IsDebugEnabled() {
                vprLogger.Debug().
                    Str("op", "sub").
          Severity: Minor
          Found in contract/system/vprt.go and 1 other location - About 1 hr to fix
          contract/system/vprt.go on lines 609..621

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 129.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status