Sign upLogin

aergoio/aergo

View on GitHub
Star
contract/vm_direct/vm_direct.go

Summary

Maintainability
F
4 days
Test Coverage

Function executeTx has a Cognitive Complexity of 74 (exceeds 20 allowed). Consider refactoring.
Open

func executeTx(
    execCtx context.Context,
    ccc consensus.ChainConsensusCluster,
    cdb contract.ChainAccessor,
    bs *state.BlockState,
Severity: Minor
Found in contract/vm_direct/vm_direct.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function executeTx has 172 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func executeTx(
    execCtx context.Context,
    ccc consensus.ChainConsensusCluster,
    cdb contract.ChainAccessor,
    bs *state.BlockState,
Severity: Major
Found in contract/vm_direct/vm_direct.go - About 5 hrs to fix

    File vm_direct.go has 515 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    package vm_direct

import (
    "bytes"
    "context"
    Severity: Minor
    Found in contract/vm_direct/vm_direct.go - About 2 hrs to fix

      Function executeTx has 20 return statements (exceeds 4 allowed).
      Open

      func executeTx(
    execCtx context.Context,
    ccc consensus.ChainConsensusCluster,
    cdb contract.ChainAccessor,
    bs *state.BlockState,
      Severity: Major
      Found in contract/vm_direct/vm_direct.go - About 1 hr to fix

        Function LoadDummyChainEx has 67 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func LoadDummyChainEx(chainType ChainType) (*DummyChain, error) {
    var err error
    var gasPrice *big.Int

    switch chainType {
        Severity: Minor
        Found in contract/vm_direct/vm_direct.go - About 1 hr to fix

          Method blockExecutor.execute has 6 return statements (exceeds 4 allowed).
          Open

          func (e *blockExecutor) execute() error {

    defer contract.CloseDatabase()

    for _, tx := range e.txs {
          Severity: Major
          Found in contract/vm_direct/vm_direct.go - About 40 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                switch txBody.Type {
    case types.TxType_NORMAL, types.TxType_REDEPLOY, types.TxType_TRANSFER, types.TxType_CALL, types.TxType_DEPLOY:
        rv, events, txFee, err = contract.Execute(execCtx, bs, cdb, tx.GetTx(), sender, receiver, bi, executionMode, false)
        sender.SubBalance(txFee)
    case types.TxType_GOVERNANCE:
            Severity: Major
            Found in contract/vm_direct/vm_direct.go and 1 other location - About 6 hrs to fix
            chain/chainhandle.go on lines 1004..1036

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 459.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if err != nil {
        // Reset events on error
        if bi.ForkVersion >= 3 {
            events = nil
        }
            Severity: Major
            Found in contract/vm_direct/vm_direct.go and 1 other location - About 5 hrs to fix
            chain/chainhandle.go on lines 1038..1086

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 385.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            func resetAccount(account *state.AccountState, fee *big.Int, nonce *uint64) error {
    account.Reset()
    if fee != nil {
        if account.Balance().Cmp(fee) < 0 {
            return &types.InternalError{Reason: "fee is greater than balance"}
            Severity: Major
            Found in contract/vm_direct/vm_direct.go and 1 other location - About 1 hr to fix
            chain/chainhandle.go on lines 932..944

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 149.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                if len(recipient) > 0 {
        receiver, err = state.GetAccountState(recipient, bs.StateDB)
        if receiver != nil && txBody.Type == types.TxType_REDEPLOY {
            status = "RECREATED"
            receiver.SetRedeploy()
            Severity: Minor
            Found in contract/vm_direct/vm_direct.go and 1 other location - About 45 mins to fix
            chain/chainhandle.go on lines 987..996

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 117.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if err != nil {
            logger.Error().Err(err).Str("hash", base58.Encode(tx.GetHash())).Msg("tx failed")
            if err2 := blockState.Rollback(blockSnap); err2 != nil {
                logger.Panic().Err(err).Msg("failed to rollback block state")
            }
            Severity: Minor
            Found in contract/vm_direct/vm_direct.go and 1 other location - About 40 mins to fix
            chain/chainhandle.go on lines 707..714

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 110.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status