Sign upLogin

aergoio/aergo

View on GitHub
Star
p2p/synctx.go

Summary

Maintainability
C
1 day
Test Coverage
C
73%

Method syncTxManager.refineFrontCache has a Cognitive Complexity of 38 (exceeds 20 allowed). Consider refactoring.
Open

func (tm *syncTxManager) refineFrontCache() {
    now := time.Now()
    expireTime := now.Add(-txQueryTimeout)
    if tm.toNoticeIdQueue.Len() == 0 { // nothing to resend
        cleanupCounter++
Severity: Minor
Found in p2p/synctx.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method syncTxManager.handleTxReq has 94 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (tm *syncTxManager) handleTxReq(remotePeer p2pcommon.RemotePeer, mID p2pcommon.MsgID, reqHashes [][]byte) {
    // NOTE size estimation is tied to protobuf3 it should be changed when protobuf is changed.
    // find transactions from chainservice
    idx := 0
    status := types.ResultStatus_OK
Severity: Major
Found in p2p/synctx.go - About 2 hrs to fix

    Method syncTxManager.refineFrontCache has 80 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (tm *syncTxManager) refineFrontCache() {
    now := time.Now()
    expireTime := now.Add(-txQueryTimeout)
    if tm.toNoticeIdQueue.Len() == 0 { // nothing to resend
        cleanupCounter++
    Severity: Major
    Found in p2p/synctx.go - About 2 hrs to fix

      Method syncTxManager.handleTxReq has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
      Open

      func (tm *syncTxManager) handleTxReq(remotePeer p2pcommon.RemotePeer, mID p2pcommon.MsgID, reqHashes [][]byte) {
    // NOTE size estimation is tied to protobuf3 it should be changed when protobuf is changed.
    // find transactions from chainservice
    idx := 0
    status := types.ResultStatus_OK
      Severity: Minor
      Found in p2p/synctx.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status