aergoio/aergo

Method GetTxsReceiver.handleInWaiting has 6 return statements (exceeds 4 allowed).

Open

func (br *GetTxsReceiver) handleInWaiting(msg p2pcommon.Message, msgBody p2pcommon.MessageBody) {
    // consuming request id when timeout, no more resp expected (i.e. hasNext == false ) or malformed body.
    // timeout
    if br.timeout.Before(time.Now()) {
        // silently ignore already status job

Identical blocks of code found in 3 locations. Consider refactoring.

Open

    if !hasNext || interval <= 0 {
        // if remote peer will not send partial response anymore. it it actually same as finish.
        br.finishReceiver()
    } else {
        // canceling in the middle of responses

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

func (br *GetTxsReceiver) ReceiveResp(msg p2pcommon.Message, msgBody p2pcommon.MessageBody) (ret bool) {
    // cases in waiting
    //   normal not status => wait
    //   normal status (last response)  => finish
    //   abnormal resp (no following resp expected): hasNext is true => cancel

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

func (br *GetTxsReceiver) ignoreMsg(msg p2pcommon.Message, msgBody p2pcommon.MessageBody) {
    body, ok := msgBody.(*types.GetTransactionsResponse)
    if !ok {
        return
    }

• Read up
  Read up