aergoio/aergo

Method V200Handshaker.checkRemoteStatus has 8 return statements (exceeds 4 allowed).

Open

func (h *V200Handshaker) checkRemoteStatus(remotePeerStatus *types.Status) error {
    // check if chainID is same or not
    remoteChainID := types.NewChainID()
    err := remoteChainID.Read(remotePeerStatus.ChainID)
    if err != nil {

Method V200Handshaker.receiveRemoteStatus has 6 return statements (exceeds 4 allowed).

Open

func (h *V200Handshaker) receiveRemoteStatus(ctx context.Context) (*types.Status, error) {
    // and wait to response status
    data, err := h.msgRW.ReadMsg()
    if err != nil {
        h.sendGoAway("malformed message")

Method V200Handshaker.DoForOutbound has 6 return statements (exceeds 4 allowed).

Open

func (h *V200Handshaker) DoForOutbound(ctx context.Context) (*p2pcommon.HandshakeResult, error) {
    h.logger.Debug().Stringer(p2putil.LogPeerID, types.LogPeerShort(h.peerID)).Msg("Starting versioned handshake for outbound peer connection")

    // find my best block
    bestBlock, err := h.is.GetChainAccessor().GetBestBlock()

Method V200Handshaker.DoForInbound has 6 return statements (exceeds 4 allowed).

Open

func (h *V200Handshaker) DoForInbound(ctx context.Context) (*p2pcommon.HandshakeResult, error) {
    h.logger.Debug().Stringer(p2putil.LogPeerID, types.LogPeerShort(h.peerID)).Msg("Starting versioned handshake for inbound peer connection")

    // inbound: receive, check and send
    remotePeerStatus, err := h.receiveRemoteStatus(ctx)

Method V200Handshaker.checkAgent has 5 return statements (exceeds 4 allowed).

Open

func (h *V200Handshaker) checkAgent(status *types.Status) error {
    h.logger.Debug().Int("certCnt", len(status.Certificates)).Stringer(p2putil.LogPeerID, types.LogPeerShort(h.remoteMeta.ID)).Msg("checking peer as agent")

    // Agent must have at least one block producer
    if len(h.remoteMeta.ProducerIDs) == 0 {

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (h *V200Handshaker) sendLocalStatus(ctx context.Context, hostStatus *types.Status) error {
    var err error
    container := createMessage(p2pcommon.StatusRequest, p2pcommon.NewMsgID(), hostStatus)
    if container == nil {
        h.logger.Warn().Stringer(p2putil.LogPeerID, types.LogPeerShort(h.peerID)).Msg("failed to create p2p message")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (h *V200Handshaker) handleGoAway(peerID types.PeerID, data p2pcommon.Message) (*types.Status, error) {
    goAway := &types.GoAwayNotice{}
    if err := p2putil.UnmarshalMessageBody(data.Payload(), goAway); err != nil {
        h.logger.Warn().Stringer(p2putil.LogPeerID, types.LogPeerShort(peerID)).Err(err).Msg("Remote peer sent goAway but failed to decode internal message")
        return nil, err

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    if data.Subprotocol() != p2pcommon.StatusRequest {
        if data.Subprotocol() == p2pcommon.GoAway {
            return h.handleGoAway(h.peerID, data)
        } else {
            h.logger.Info().Stringer(p2putil.LogPeerID, types.LogPeerShort(h.peerID)).Str("expected", p2pcommon.StatusRequest.String()).Str("actual", data.Subprotocol().String()).Msg("unexpected message type")

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

func createMessage(protocolID p2pcommon.SubProtocol, msgID p2pcommon.MsgID, msgBody p2pcommon.MessageBody) p2pcommon.Message {
    bytes, err := p2putil.MarshalMessageBody(msgBody)
    if err != nil {
        return nil
    }

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    if rMeta.ID != h.peerID {
        h.logger.Debug().Str("received_peer_id", rMeta.ID.Pretty()).Stringer(p2putil.LogPeerID, types.LogPeerShort(h.peerID)).Msg("Inconsistent peerID")
        h.sendGoAway("Inconsistent peerID")
        return fmt.Errorf("inconsistent peerID")
    }

• Read up
  Read up