aergoio/aergo

View on GitHub
rpc/rpc.go

Summary

Maintainability
D
1 day
Test Coverage
F
2%

Method RPC.Receive has a Cognitive Complexity of 62 (exceeds 20 allowed). Consider refactoring.
Open

func (ns *RPC) Receive(context actor.Context) {
    switch msg := context.Message().(type) {
    case *types.Block:
        server := ns.actualServer
        server.BroadcastToListBlockStream(msg)
Severity: Minor
Found in rpc/rpc.go - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function NewRPC has 74 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func NewRPC(cfg *config.Config, chainAccessor types.ChainAccessor, version string) *RPC {
    actualServer := &AergoRPCService{
        msgHelper:           message.GetHelper(),
        blockStream:         make(map[uint32]*ListBlockStream),
        blockMetadataStream: make(map[uint32]*ListBlockMetaStream),
Severity: Minor
Found in rpc/rpc.go - About 1 hr to fix

    Method RPC.Receive has 73 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (ns *RPC) Receive(context actor.Context) {
        switch msg := context.Message().(type) {
        case *types.Block:
            server := ns.actualServer
            server.BroadcastToListBlockStream(msg)
    Severity: Minor
    Found in rpc/rpc.go - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                              if e.JsonArgs == "true" {
                                  value = true
                              }
      Severity: Major
      Found in rpc/rpc.go - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            } else if conf == enterprise.AccountWhite {
                                values := make([]string, 1024)
                                if err := json.Unmarshal([]byte(e.JsonArgs), &values); err != nil {
                                    return
                                }
        Severity: Major
        Found in rpc/rpc.go - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              } else if conf == enterprise.AccountWhite {
                                  value := false
                                  if e.JsonArgs == "true" {
                                      value = true
                                  }
          Severity: Major
          Found in rpc/rpc.go - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if err := json.Unmarshal([]byte(e.JsonArgs), &values); err != nil {
                                        return
                                    }
            Severity: Major
            Found in rpc/rpc.go - About 45 mins to fix

              There are no issues that match your filters.

              Category
              Status