aergoio/aergo

View on GitHub
types/receipt.go

Summary

Maintainability
D
2 days
Test Coverage
F
0%

File receipt.go has 816 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package types

import (
    "bytes"
    "encoding/binary"
Severity: Major
Found in types/receipt.go - About 1 day to fix

    Function checkValue has 6 return statements (exceeds 4 allowed).
    Open

    func checkValue(value interface{}, check interface{}) bool {
        if reflect.TypeOf(value) != reflect.TypeOf(check) {
            return false
        }
        switch value.(type) {
    Severity: Major
    Found in types/receipt.go - About 40 mins to fix

      Method Event.Filter has 6 return statements (exceeds 4 allowed).
      Open

      func (ev *Event) Filter(filter *FilterInfo, argFilter []ArgFilter) bool {
          if filter.ContractAddress != nil && !bytes.Equal(ev.ContractAddress, filter.ContractAddress) {
              return false
          }
          if len(filter.EventName) != 0 && ev.EventName != filter.EventName {
      Severity: Major
      Found in types/receipt.go - About 40 mins to fix

        Method FilterInfo.ValidateCheck has 5 return statements (exceeds 4 allowed).
        Open

        func (fi *FilterInfo) ValidateCheck(to uint64) error {
            if fi.ContractAddress == nil {
                return errors.New("invalid contractAddress:" + string(fi.ContractAddress))
            }
            if len(fi.ContractAddress) < AddressLength {
        Severity: Major
        Found in types/receipt.go - About 35 mins to fix

          Method FilterInfo.GetExArgFilter has 5 return statements (exceeds 4 allowed).
          Open

          func (fi *FilterInfo) GetExArgFilter() ([]ArgFilter, error) {
              if len(fi.ArgFilter) == 0 {
                  return nil, nil
              }
          
          
          Severity: Major
          Found in types/receipt.go - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (r *Receipt) unmarshalStoreBinaryV2(data []byte) ([]byte, error) {
                evData, evCount := r.unmarshalBodyV2(data)
            
                r.Events = make([]*Event, evCount)
                var err error
            Severity: Major
            Found in types/receipt.go and 1 other location - About 1 hr to fix
            types/receipt.go on lines 251..265

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 161.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (r *Receipt) unmarshalStoreBinary(data []byte) ([]byte, error) {
                evData, evCount := r.unmarshalBody(data)
            
                r.Events = make([]*Event, evCount)
                var err error
            Severity: Major
            Found in types/receipt.go and 1 other location - About 1 hr to fix
            types/receipt.go on lines 267..281

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 161.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (r *Receipt) marshalStoreBinary() ([]byte, error) {
                var b bytes.Buffer
            
                err := r.marshalBody(&b, false)
                if err != nil {
            Severity: Major
            Found in types/receipt.go and 1 other location - About 1 hr to fix
            types/receipt.go on lines 146..162

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 137.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (r *Receipt) marshalStoreBinaryV2() ([]byte, error) {
                var b bytes.Buffer
            
                err := r.marshalBodyV2(&b, false)
                if err != nil {
            Severity: Major
            Found in types/receipt.go and 1 other location - About 1 hr to fix
            types/receipt.go on lines 128..144

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 137.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (r *Receipt) MarshalMerkleBinary() ([]byte, error) {
                var b bytes.Buffer
            
                err := r.marshalBody(&b, true)
                if err != nil {
            Severity: Major
            Found in types/receipt.go and 1 other location - About 1 hr to fix
            types/receipt.go on lines 306..323

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 135.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (r *Receipt) MarshalMerkleBinaryV2() ([]byte, error) {
                var b bytes.Buffer
            
                err := r.marshalBodyV2(&b, true)
                if err != nil {
            Severity: Major
            Found in types/receipt.go and 1 other location - About 1 hr to fix
            types/receipt.go on lines 287..304

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 135.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status