Sign upLogin

aesy/reddit-comment-highlights

View on GitHub
Star
src/registry/RemoteFunctionBrowserExtensionRegistry.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function invoke has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public async invoke<T, R>(key: string, arg?: T): Promise<R> {
        const func = this.functions.get(key as string);

        if (func) {
            // Function is not remote
Severity: Minor
Found in src/registry/RemoteFunctionBrowserExtensionRegistry.ts - About 1 hr to fix

    Function messageListener has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @bind
    private messageListener(request: object | void): Promise<InvocationResponse<unknown>> | void {
        if (!request) {
            return;
        }
    Severity: Minor
    Found in src/registry/RemoteFunctionBrowserExtensionRegistry.ts - About 1 hr to fix

      Function messageListener has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          @bind
    private messageListener(request: object | void): Promise<InvocationResponse<unknown>> | void {
        if (!request) {
            return;
        }
      Severity: Minor
      Found in src/registry/RemoteFunctionBrowserExtensionRegistry.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

                      return Promise.resolve({ method, error });
      Severity: Major
      Found in src/registry/RemoteFunctionBrowserExtensionRegistry.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                            return Promise.resolve({ method, result: returnValue });
        Severity: Major
        Found in src/registry/RemoteFunctionBrowserExtensionRegistry.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return Promise.resolve({
                method,
                error: `No such function with name ${ name }`
            });
          Severity: Major
          Found in src/registry/RemoteFunctionBrowserExtensionRegistry.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return resolve(invocationResponse.result);
            Severity: Major
            Found in src/registry/RemoteFunctionBrowserExtensionRegistry.ts - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public constructor(
        private readonly browser: Browser
    ) {
        if (this.browser.runtime) {
            this.browser.runtime.onMessage.addListener(this.messageListener);
              Severity: Minor
              Found in src/registry/RemoteFunctionBrowserExtensionRegistry.ts and 1 other location - About 35 mins to fix
              src/event/BrowserExtensionEvent.ts on lines 58..62

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status