Sign upLogin

af83/chouette-core

View on GitHub
Star
app/packs/src/helpers/open_layers/styles.js

Summary

Maintainability
C
1 day
Test Coverage

Function lineStyle has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const lineStyle = ([_line, ...waypoints]) => {
    const styles = [
        new Style({
            stroke: new Stroke({
                color: '#007fbb',
Severity: Major
Found in app/packs/src/helpers/open_layers/styles.js - About 2 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            new Style({
            image: new Circle({
                radius: 5,
                stroke: new Stroke({
                    color: '#007fbb',
    Severity: Major
    Found in app/packs/src/helpers/open_layers/styles.js and 2 other locations - About 1 hr to fix
    app/packs/src/helpers/open_layers/styles.js on lines 154..166
    app/packs/src/helpers/open_layers/styles.js on lines 177..189

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                    new Style({
                    image: new Circle({
                        radius: 4,
                        stroke: new Stroke({
                            color: '#007fbb',
    Severity: Major
    Found in app/packs/src/helpers/open_layers/styles.js and 2 other locations - About 1 hr to fix
    app/packs/src/helpers/open_layers/styles.js on lines 141..153
    app/packs/src/helpers/open_layers/styles.js on lines 154..166

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            new Style({
            image: new Circle({
                radius: 5,
                stroke: new Stroke({
                    color: '#007fbb',
    Severity: Major
    Found in app/packs/src/helpers/open_layers/styles.js and 2 other locations - About 1 hr to fix
    app/packs/src/helpers/open_layers/styles.js on lines 141..153
    app/packs/src/helpers/open_layers/styles.js on lines 177..189

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            shapeConstraint: new Style({
            image: new Circle({
                radius: 8,
                stroke: new Stroke({ color: 'red', width: 2 }),
                fill: new Fill({ color: 'white' })
    Severity: Major
    Found in app/packs/src/helpers/open_layers/styles.js and 3 other locations - About 1 hr to fix
    app/packs/src/helpers/open_layers/styles.js on lines 76..82
    app/packs/src/helpers/open_layers/styles.js on lines 91..97
    app/packs/src/helpers/open_layers/styles.js on lines 98..104

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            shapeWaypoint: new Style({
            image: new Circle({
                radius: 8,
                stroke: new Stroke({ color: 'white', width: 2 }),
                fill: new Fill({ color: 'red' })
    Severity: Major
    Found in app/packs/src/helpers/open_layers/styles.js and 3 other locations - About 1 hr to fix
    app/packs/src/helpers/open_layers/styles.js on lines 83..89
    app/packs/src/helpers/open_layers/styles.js on lines 91..97
    app/packs/src/helpers/open_layers/styles.js on lines 98..104

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                default: new Style({
                image: new Circle({
                    radius: 5,
                    stroke: new Stroke({ color: '#007fbb', width: 0.75 }),
                    fill: new Fill({ color: '#ffffff' })
    Severity: Major
    Found in app/packs/src/helpers/open_layers/styles.js and 3 other locations - About 1 hr to fix
    app/packs/src/helpers/open_layers/styles.js on lines 76..82
    app/packs/src/helpers/open_layers/styles.js on lines 83..89
    app/packs/src/helpers/open_layers/styles.js on lines 98..104

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                edge: new Style({
                image: new Circle({
                    radius: 5,
                    stroke: new Stroke({ color: '#007fbb', width: 0.75 }),
                    fill: new Fill({ color: '#007fbb' })
    Severity: Major
    Found in app/packs/src/helpers/open_layers/styles.js and 3 other locations - About 1 hr to fix
    app/packs/src/helpers/open_layers/styles.js on lines 76..82
    app/packs/src/helpers/open_layers/styles.js on lines 83..89
    app/packs/src/helpers/open_layers/styles.js on lines 91..97

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status