af83/chouette-core

View on GitHub
app/packs/src/journey_patterns/actions/index.js

Summary

Maintainability
D
2 days
Test Coverage

actions has 30 functions (exceeds 20 allowed). Consider refactoring.
Open

const actions = {
  enterEditMode: () => ({
    type: "ENTER_EDIT_MODE"
  }),
  exitEditMode: () => ({
Severity: Minor
Found in app/packs/src/journey_patterns/actions/index.js - About 3 hrs to fix

    Function fetchJourneyPatterns has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      fetchJourneyPatterns : (dispatch, currentPage, nextPage) => {
        if(currentPage == undefined){
          currentPage = 1
        }
        let journeyPatterns = []
    Severity: Major
    Found in app/packs/src/journey_patterns/actions/index.js - About 2 hrs to fix

      File index.js has 271 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      const actions = {
        enterEditMode: () => ({
          type: "ENTER_EDIT_MODE"
        }),
        exitEditMode: () => ({
      Severity: Minor
      Found in app/packs/src/journey_patterns/actions/index.js - About 2 hrs to fix

        Function submitJourneyPattern has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          submitJourneyPattern : (dispatch, state, next) => {
            dispatch(actions.fetchingApi())
            let urlJSON = window.location.pathname + ".json"
            let hasError = false
            fetch(urlJSON, {
        Severity: Minor
        Found in app/packs/src/journey_patterns/actions/index.js - About 1 hr to fix

          Function fetchRouteCosts has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            fetchRouteCosts: (dispatch, key, index) => {
              if(actions.fetchingRouteCosts){
                  // A request is already sent, wait for it
                  if(!actions.waitingForRouteCosts){
                    actions.waitingForRouteCosts = []
          Severity: Minor
          Found in app/packs/src/journey_patterns/actions/index.js - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                              if(element.stop_area_short_description.position === stop_point.position){
                                stop_point.checked = true
                              }
            Severity: Major
            Found in app/packs/src/journey_patterns/actions/index.js - About 45 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  fetch(urlJSON, {
                    credentials: 'same-origin',
                    method: 'PATCH',
                    contentType: 'application/json; charset=utf-8',
                    Accept: 'application/json',
              Severity: Major
              Found in app/packs/src/journey_patterns/actions/index.js and 1 other location - About 3 hrs to fix
              app/packs/src/vehicle_journeys/actions/index.js on lines 462..491

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 112.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 3 locations. Consider refactoring.
              Open

                  return fetch(urlJSON, {
                    credentials: 'same-origin',
                  }).then(response => {
                      if(response.status == 500) {
                        hasError = true
              Severity: Major
              Found in app/packs/src/journey_patterns/actions/index.js and 2 other locations - About 1 hr to fix
              app/packs/src/time_tables/actions/index.js on lines 249..266
              app/packs/src/vehicle_journeys/actions/index.js on lines 392..444

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 63.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  switch (nextPage) {
                    case true:
                      page = currentPage + 1
                      break
                    case false:
              Severity: Major
              Found in app/packs/src/journey_patterns/actions/index.js and 1 other location - About 1 hr to fix
              app/packs/src/vehicle_journeys/actions/index.js on lines 367..379

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 57.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                checkConfirmModal : (event, callback, stateChanged,dispatch) => {
                  if(stateChanged === true){
                    return actions.openConfirmModal(callback)
                  }else{
                    dispatch(actions.fetchingApi())
              Severity: Major
              Found in app/packs/src/journey_patterns/actions/index.js and 1 other location - About 1 hr to fix
              app/packs/src/vehicle_journeys/actions/index.js on lines 77..84

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 57.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                resetValidation: (target) => {
                  $(target).parent().removeClass('has-error').children('.help-block').remove()
                },
              Severity: Minor
              Found in app/packs/src/journey_patterns/actions/index.js and 1 other location - About 40 mins to fix
              app/packs/src/vehicle_journeys/actions/index.js on lines 252..254

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 48.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                        if(json.length != window.currentItemsLength){
                          dispatch(actions.updateTotalCount(window.currentItemsLength - json.length))
                        }
              Severity: Minor
              Found in app/packs/src/journey_patterns/actions/index.js and 1 other location - About 35 mins to fix
              app/packs/src/vehicle_journeys/actions/index.js on lines 483..485

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status