Sign upLogin

af83/chouette-core

View on GitHub
Star
app/packs/src/vehicle_journeys/reducers/vehicleJourneys.js

Summary

Maintainability
F
3 days
Test Coverage

Function vehicleJourney has 193 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const vehicleJourney= (state = {}, action, keep) => {
  switch (action.type) {
    case 'SELECT_VEHICLEJOURNEY':
      return _.assign({}, state, {selected: !state.selected})
    case 'CANCEL_SELECTION':
Severity: Major
Found in app/packs/src/vehicle_journeys/reducers/vehicleJourneys.js - About 7 hrs to fix

    Function vehicleJourneys has 161 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export default function vehicleJourneys(state = [], action) {
  switch (action.type) {
    case 'RECEIVE_VEHICLE_JOURNEYS':
      return [...action.json]
    case 'RECEIVE_ERRORS':
    Severity: Major
    Found in app/packs/src/vehicle_journeys/reducers/vehicleJourneys.js - About 6 hrs to fix

      File vehicleJourneys.js has 360 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import _ from 'lodash'
import actions from '../actions'

const vehicleJourney= (state = {}, action, keep) => {
  switch (action.type) {
      Severity: Minor
      Found in app/packs/src/vehicle_journeys/reducers/vehicleJourneys.js - About 4 hrs to fix

        Function vehicleJourney has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

        const vehicleJourney= (state = {}, action, keep) => {
  switch (action.type) {
    case 'SELECT_VEHICLEJOURNEY':
      return _.assign({}, state, {selected: !state.selected})
    case 'CANCEL_SELECTION':
        Severity: Minor
        Found in app/packs/src/vehicle_journeys/reducers/vehicleJourneys.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Consider simplifying this complex logical expression.
        Open

              if(action.data["start_time.hour"] && action.data["start_time.hour"].value && action.data["start_time.hour"].value.length > 0 && action.data["start_time.minute"] && action.selectedJourneyPattern.full_schedule && action.selectedJourneyPattern.costs){
        computeSchedule = true
        initTZOffet = - action.stopPointsList[0].time_zone_offset / 60 || 0
        current_time.hour = parseInt(action.data["start_time.hour"].value) + parseInt(initTZOffet / 60)
        current_time.minute = 0
        Severity: Major
        Found in app/packs/src/vehicle_journeys/reducers/vehicleJourneys.js - About 1 hr to fix

          Avoid too many return statements within this function.
          Open

                return concatArray.map((vj, i) => {
        vj.index = i
        return vj
      })
          Severity: Major
          Found in app/packs/src/vehicle_journeys/reducers/vehicleJourneys.js - About 30 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        return _.assign({}, state.vehicle_journey_at_stops[action.subIndex],  {arrival_time: newSchedule.arrival_time, departure_time: newSchedule.departure_time, delta: newSchedule.delta})
            Severity: Minor
            Found in app/packs/src/vehicle_journeys/reducers/vehicleJourneys.js and 1 other location - About 55 mins to fix
            app/packs/src/vehicle_journeys/reducers/vehicleJourneys.js on lines 200..200

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        return _.assign({}, state.vehicle_journey_at_stops[action.subIndex], {arrival_time: newSchedule.arrival_time, departure_time: newSchedule.departure_time, delta: newSchedule.delta})
            Severity: Minor
            Found in app/packs/src/vehicle_journeys/reducers/vehicleJourneys.js and 1 other location - About 55 mins to fix
            app/packs/src/vehicle_journeys/reducers/vehicleJourneys.js on lines 204..204

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                case 'UPDATE_TIME':
      return state.map((vj, i) => {
        if (i == action.index){
          return vehicleJourney(vj, action)
        } else {
            Severity: Major
            Found in app/packs/src/vehicle_journeys/reducers/vehicleJourneys.js and 2 other locations - About 50 mins to fix
            app/packs/src/journey_patterns/reducers/journeyPatterns.js on lines 68..75
            app/packs/src/vehicle_journeys/reducers/vehicleJourneys.js on lines 348..355

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                case 'SELECT_VEHICLEJOURNEY':
      return state.map((vj, i) => {
        if (i == action.index){
          return vehicleJourney(vj, action)
        } else {
            Severity: Major
            Found in app/packs/src/vehicle_journeys/reducers/vehicleJourneys.js and 2 other locations - About 50 mins to fix
            app/packs/src/journey_patterns/reducers/journeyPatterns.js on lines 68..75
            app/packs/src/vehicle_journeys/reducers/vehicleJourneys.js on lines 368..375

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                case 'SELECT_SPECIFIC_STOP':
      return state.map((vj, i) => {
        if (vj.selected){
          return vehicleJourney(vj, action, true)
        }else{
            Severity: Minor
            Found in app/packs/src/vehicle_journeys/reducers/vehicleJourneys.js and 1 other location - About 40 mins to fix
            app/packs/src/vehicle_journeys/reducers/vehicleJourneys.js on lines 294..301

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                case 'SHIFT_VEHICLEJOURNEY':
      return state.map((vj, i) => {
        if (vj.selected){
          return vehicleJourney(vj, action, true)
        }else{
            Severity: Minor
            Found in app/packs/src/vehicle_journeys/reducers/vehicleJourneys.js and 1 other location - About 40 mins to fix
            app/packs/src/vehicle_journeys/reducers/vehicleJourneys.js on lines 302..309

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status