Sign upLogin

af83/edwig

View on GitHub
Star
api/push_handler.go

Summary

Maintainability
A
3 hrs
Test Coverage

Method PushHandler.serve has 57 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (handler *PushHandler) serve(response http.ResponseWriter, request *http.Request) {
    // Check if request header is protobuf or return an error
    if request.Header.Get("Content-Type") != "application/x-protobuf" {
        http.Error(response, "Expected application/x-protobuf content", http.StatusUnsupportedMediaType)
        return
Severity: Minor
Found in api/push_handler.go - About 1 hr to fix

    Method PushHandler.serve has 8 return statements (exceeds 4 allowed).
    Open

    func (handler *PushHandler) serve(response http.ResponseWriter, request *http.Request) {
    // Check if request header is protobuf or return an error
    if request.Header.Get("Content-Type") != "application/x-protobuf" {
        http.Error(response, "Expected application/x-protobuf content", http.StatusUnsupportedMediaType)
        return
    Severity: Major
    Found in api/push_handler.go - About 50 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      func (handler *PushHandler) logError(m *audit.BigQueryMessage, startTime time.Time, format string, values ...interface{}) {
    m.ProcessingTime = handler.referential.Clock().Since(startTime).Seconds()
    m.Status = "Error"
    errorString := fmt.Sprintf(format, values...)
      Severity: Major
      Found in api/push_handler.go and 2 other locations - About 1 hr to fix
      api/graphql_handler.go on lines 93..100
      api/gtfs_handler.go on lines 146..153

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 135.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status