Sign upLogin

af83/edwig

View on GitHub
Star
core/broadcast_general_message_builder.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method BroadcastGeneralMessageBuilder.BuildGeneralMessage has 64 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (builder *BroadcastGeneralMessageBuilder) BuildGeneralMessage(situation model.Situation) *siri.SIRIGeneralMessage {
    if !builder.canBroadcast(situation) {
        return nil
    }
Severity: Minor
Found in core/broadcast_general_message_builder.go - About 1 hr to fix

    Method BroadcastGeneralMessageBuilder.BuildGeneralMessage has 6 return statements (exceeds 4 allowed).
    Open

    func (builder *BroadcastGeneralMessageBuilder) BuildGeneralMessage(situation model.Situation) *siri.SIRIGeneralMessage {
    if !builder.canBroadcast(situation) {
        return nil
    }
    Severity: Major
    Found in core/broadcast_general_message_builder.go - About 40 mins to fix

      Method BroadcastGeneralMessageBuilder.canBroadcast has 5 return statements (exceeds 4 allowed).
      Open

      func (builder *BroadcastGeneralMessageBuilder) canBroadcast(situation model.Situation) bool {
    if situation.Origin == string(builder.partner.Slug()) {
        return false
    }
      Severity: Major
      Found in core/broadcast_general_message_builder.go - About 35 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func (builder *BroadcastGeneralMessageBuilder) resolveStopAreaRef(stopAreaId model.StopAreaId) (string, bool) {
    stopArea, ok := builder.partner.Model().StopAreas().Find(stopAreaId)
    if !ok {
        return "", false
    }
        Severity: Major
        Found in core/broadcast_general_message_builder.go and 2 other locations - About 50 mins to fix
        core/broadcast_situation_exchange_builder.go on lines 241..251
        core/siri_situation_exchange_request_broadcaster.go on lines 267..277

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 121.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (builder *BroadcastGeneralMessageBuilder) SetLineRef(lineRef []string) {
    if (len(lineRef) == 0) || (len(lineRef) == 1 && lineRef[0] == "") {
        return
    }
        Severity: Minor
        Found in core/broadcast_general_message_builder.go and 1 other location - About 30 mins to fix
        core/broadcast_general_message_builder.go on lines 45..53

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 100.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (builder *BroadcastGeneralMessageBuilder) SetStopPointRef(stopPointRef []string) {
    if (len(stopPointRef) == 0) || (len(stopPointRef) == 1 && stopPointRef[0] == "") {
        return
    }
        Severity: Minor
        Found in core/broadcast_general_message_builder.go and 1 other location - About 30 mins to fix
        core/broadcast_general_message_builder.go on lines 35..43

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 100.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status