Sign upLogin

af83/edwig

View on GitHub
Star
core/partner.go

Summary

Maintainability
D
3 days
Test Coverage

File partner.go has 818 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package core

import (
    "encoding/json"
    "errors"
Severity: Major
Found in core/partner.go - About 1 day to fix

    Partner has 59 methods (exceeds 20 allowed). Consider refactoring.
    Open

    type Partner struct {
    uuid.UUIDConsumer
    *s.PartnerSettings

    mutex *sync.RWMutex
    Severity: Major
    Found in core/partner.go - About 1 day to fix

      PartnerManager has 21 methods (exceeds 20 allowed). Consider refactoring.
      Open

      type PartnerManager struct {
    uuid.UUIDConsumer

    mutex *sync.RWMutex
      Severity: Minor
      Found in core/partner.go - About 2 hrs to fix

        Method Partner.hasSubscribers has 8 return statements (exceeds 4 allowed).
        Open

        func (partner *Partner) hasSubscribers() bool {
    _, ok := partner.connectors[SIRI_STOP_MONITORING_SUBSCRIPTION_BROADCASTER]
    if ok {
        return true
    }
        Severity: Major
        Found in core/partner.go - About 50 mins to fix

          Method PartnerManager.SaveToDatabase has 8 return statements (exceeds 4 allowed).
          Open

          func (manager *PartnerManager) SaveToDatabase() (int, error) {
    // Check presence of Referential
    selectReferentials := []model.SelectReferential{}
    sqlQuery := fmt.Sprintf("select * from referentials where referential_id = '%s'", manager.referential.Id())
    _, err := model.Database.Select(&selectReferentials, sqlQuery)
          Severity: Major
          Found in core/partner.go - About 50 mins to fix

            Method Partner.CanCollectLines has 5 return statements (exceeds 4 allowed).
            Open

            func (partner *Partner) CanCollectLines(lineIds map[string]struct{}) s.CollectStatus {
    if len(lineIds) == 0 {
        return s.COLLECT_UNKNOWN
    }
            Severity: Major
            Found in core/partner.go - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  for _, partner := range manager.byId {
        dbPartner, err := manager.newDbPartner(partner)
        if err != nil {
            tx.Rollback()
            return http.StatusInternalServerError, fmt.Errorf("internal error: %v", err)
              Severity: Minor
              Found in core/partner.go and 1 other location - About 45 mins to fix
              core/referential.go on lines 425..436

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 113.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func (partner *Partner) RegisterDiscoveredStopAreas(stops []string) {
    if !partner.CollectSettings().UseDiscoveredSA {
        return
    }
              Severity: Minor
              Found in core/partner.go and 1 other location - About 30 mins to fix
              core/partner.go on lines 713..725

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 102.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func (partner *Partner) RegisterDiscoveredLines(lines []string) {
    if !partner.CollectSettings().UseDiscoveredLines {
        return
    }
              Severity: Minor
              Found in core/partner.go and 1 other location - About 30 mins to fix
              core/partner.go on lines 699..711

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 102.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status