Sign upLogin

af83/edwig

View on GitHub
Star
core/siri_estimated_timetable_request_broadcaster.go

Summary

Maintainability
C
1 day
Test Coverage

Method SIRIEstimatedTimetableRequestBroadcaster.getEstimatedTimetableDelivery has a Cognitive Complexity of 61 (exceeds 20 allowed). Consider refactoring.
Open

func (connector *SIRIEstimatedTimetableRequestBroadcaster) getEstimatedTimetableDelivery(request *sxml.XMLEstimatedTimetableRequest) siri.SIRIEstimatedTimetableDelivery {
    currentTime := connector.Clock().Now()

    delivery := siri.SIRIEstimatedTimetableDelivery{
        RequestMessageRef:  request.MessageIdentifier(),
Severity: Minor
Found in core/siri_estimated_timetable_request_broadcaster.go - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method SIRIEstimatedTimetableRequestBroadcaster.getEstimatedTimetableDelivery has 118 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (connector *SIRIEstimatedTimetableRequestBroadcaster) getEstimatedTimetableDelivery(request *sxml.XMLEstimatedTimetableRequest) siri.SIRIEstimatedTimetableDelivery {
    currentTime := connector.Clock().Now()

    delivery := siri.SIRIEstimatedTimetableDelivery{
        RequestMessageRef:  request.MessageIdentifier(),
Severity: Major
Found in core/siri_estimated_timetable_request_broadcaster.go - About 3 hrs to fix

    Method SIRIEstimatedTimetableRequestBroadcaster.stopPointRef has 5 return statements (exceeds 4 allowed).
    Open

    func (connector *SIRIEstimatedTimetableRequestBroadcaster) stopPointRef(stopAreaId model.StopAreaId) (*model.StopArea, string, bool) {
    stopPointRef, ok := connector.partner.Model().StopAreas().Find(stopAreaId)
    if !ok {
        return &model.StopArea{}, "", false
    }
    Severity: Major
    Found in core/siri_estimated_timetable_request_broadcaster.go - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (connector *SIRIEstimatedTimetableRequestBroadcaster) publishedLineName(line *model.Line) string {
    var pln string

    switch connector.partner.PartnerSettings.SIRILinePublishedName() {
    case "number":
      Severity: Minor
      Found in core/siri_estimated_timetable_request_broadcaster.go and 1 other location - About 50 mins to fix
      core/production_timetable_broadcaster.go on lines 247..262

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 120.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          if request.PreviewInterval() != 0 {
        duration := request.PreviewInterval()
        now := connector.Clock().Now()
        if !request.StartTime().IsZero() {
            now = request.StartTime()
      Severity: Minor
      Found in core/siri_estimated_timetable_request_broadcaster.go and 1 other location - About 30 mins to fix
      core/siri_stop_monitoring_request_broadcaster.go on lines 73..80

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status