Sign upLogin

af83/edwig

View on GitHub
Star
core/siri_stop_monitoring_subscriber.go

Summary

Maintainability
C
1 day
Test Coverage

Method SMSubscriber.prepareSIRIStopMonitoringSubscriptionRequest has 92 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (subscriber *SMSubscriber) prepareSIRIStopMonitoringSubscriptionRequest() {
    subscriptions := subscriber.connector.partner.Subscriptions().FindSubscriptionsByKind(StopMonitoringCollect)
    if len(subscriptions) == 0 {
        logger.Log.Debugf("StopMonitoringSubscriber visit without StopMonitoringCollect subscriptions")
        return
Severity: Major
Found in core/siri_stop_monitoring_subscriber.go - About 2 hrs to fix

    Method SMSubscriber.prepareSIRIStopMonitoringSubscriptionRequest has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
    Open

    func (subscriber *SMSubscriber) prepareSIRIStopMonitoringSubscriptionRequest() {
    subscriptions := subscriber.connector.partner.Subscriptions().FindSubscriptionsByKind(StopMonitoringCollect)
    if len(subscriptions) == 0 {
        logger.Log.Debugf("StopMonitoringSubscriber visit without StopMonitoringCollect subscriptions")
        return
    Severity: Minor
    Found in core/siri_stop_monitoring_subscriber.go - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        for _, responseStatus := range response.ResponseStatus() {
        requestedSa, ok := stopAreasToRequest[responseStatus.RequestMessageRef()]
        if !ok {
            logger.Log.Debugf("ResponseStatus RequestMessageRef unknown: %v", responseStatus.RequestMessageRef())
            continue
    Severity: Major
    Found in core/siri_stop_monitoring_subscriber.go and 1 other location - About 3 hrs to fix
    core/siri_general_message_subscriber.go on lines 178..205

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 295.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        for messageIdentifier, requestedSa := range stopAreasToRequest {
        entry := &siri.SIRIStopMonitoringSubscriptionRequestEntry{
            SubscriberRef:          subscriber.connector.Partner().RequestorRef(),
            SubscriptionIdentifier: string(requestedSa.subId),
            InitialTerminationTime: subscriber.Clock().Now().Add(48 * time.Hour),
    Severity: Major
    Found in core/siri_stop_monitoring_subscriber.go and 1 other location - About 1 hr to fix
    core/siri_vehicle_monitoring_subscriber.go on lines 127..140

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 186.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    func (subscriber *StopMonitoringSubscriber) run() {
    c := subscriber.Clock().After(5 * time.Second)

    for {
        select {
    Severity: Major
    Found in core/siri_stop_monitoring_subscriber.go and 4 other locations - About 55 mins to fix
    core/siri_estimated_timetable_subscriber.go on lines 46..61
    core/siri_general_message_subscriber.go on lines 67..82
    core/siri_situation_exchange_subscriber.go on lines 44..59
    core/siri_vehicle_monitoring_subscriber.go on lines 67..82

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 127.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    func (subscriber *SMSubscriber) incrementRetryCountFromMap(stopAreasToRequest map[string]*saToRequest) {
    for _, requestedSa := range stopAreasToRequest {
        subscription, ok := subscriber.connector.partner.Subscriptions().Find(requestedSa.subId)
        if !ok { // Should never happen
            continue
    Severity: Major
    Found in core/siri_stop_monitoring_subscriber.go and 3 other locations - About 50 mins to fix
    core/siri_general_message_subscriber.go on lines 213..225
    core/siri_situation_exchange_subscriber.go on lines 191..203
    core/siri_vehicle_monitoring_subscriber.go on lines 212..224

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 118.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        for _, subscription := range subscriptions {
        for _, resource := range subscription.ResourcesByCodeCopy() {
            if resource.SubscribedAt().IsZero() && resource.RetryCount <= 10 {
                messageIdentifier := subscriber.connector.Partner().NewMessageIdentifier()
                stopAreasToRequest[messageIdentifier] = &saToRequest{
    Severity: Minor
    Found in core/siri_stop_monitoring_subscriber.go and 1 other location - About 45 mins to fix
    core/siri_vehicle_monitoring_subscriber.go on lines 100..110

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 117.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status