Sign upLogin

af83/edwig

View on GitHub
Star
model/diff.go

Summary

Maintainability
C
1 day
Test Coverage

Function deepValueEqual has a Cognitive Complexity of 55 (exceeds 20 allowed). Consider refactoring.
Open

func deepValueEqual(v1, v2 reflect.Value, visited map[visit]bool) bool {
    if !v1.IsValid() || !v2.IsValid() {
        return v1.IsValid() == v2.IsValid()
    }
    if v1.Type() != v2.Type() {
Severity: Minor
Found in model/diff.go - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function deepValueEqual has 93 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func deepValueEqual(v1, v2 reflect.Value, visited map[visit]bool) bool {
    if !v1.IsValid() || !v2.IsValid() {
        return v1.IsValid() == v2.IsValid()
    }
    if v1.Type() != v2.Type() {
Severity: Major
Found in model/diff.go - About 2 hrs to fix

    Function deepValueEqual has 22 return statements (exceeds 4 allowed).
    Open

    func deepValueEqual(v1, v2 reflect.Value, visited map[visit]bool) bool {
    if !v1.IsValid() || !v2.IsValid() {
        return v1.IsValid() == v2.IsValid()
    }
    if v1.Type() != v2.Type() {
    Severity: Major
    Found in model/diff.go - About 2 hrs to fix

      There are no issues that match your filters.

      Category
      Status