Sign upLogin

af83/edwig

View on GitHub
Star
model/situation.go

Summary

Maintainability
D
1 day
Test Coverage

File situation.go has 789 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package model

import (
    "encoding/json"
    "errors"
Severity: Major
Found in model/situation.go - About 1 day to fix

    Function AffectToProto has 60 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func AffectToProto(a Affect, remoteCodeSpace string, m Model) ([]*gtfs.EntitySelector, *AffectRefs, error) {
    collectedRefs := &AffectRefs{
        MonitoringRefs: make(map[string]struct{}),
        LineRefs:       make(map[string]struct{}),
    }
    Severity: Minor
    Found in model/situation.go - About 1 hr to fix

      Function AffectToProto has 7 return statements (exceeds 4 allowed).
      Open

      func AffectToProto(a Affect, remoteCodeSpace string, m Model) ([]*gtfs.EntitySelector, *AffectRefs, error) {
    collectedRefs := &AffectRefs{
        MonitoringRefs: make(map[string]struct{}),
        LineRefs:       make(map[string]struct{}),
    }
      Severity: Major
      Found in model/situation.go - About 45 mins to fix

        Function AffectFromProto has 5 return statements (exceeds 4 allowed).
        Open

        func AffectFromProto(value interface{}, remoteCodeSpace string, m Model) (Affect, *AffectRefs, error) {
    collectedRefs := &AffectRefs{
        MonitoringRefs: make(map[string]struct{}),
        LineRefs:       make(map[string]struct{}),
    }
        Severity: Major
        Found in model/situation.go - About 35 mins to fix

          Method APISituation.Validate has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
          Open

          func (apiSituation *APISituation) Validate() bool {
    if apiSituation.CodeSpace == "" {
        apiSituation.Errors.Add("CodeSpace", e.ERROR_BLANK)
    }
          Severity: Minor
          Found in model/situation.go - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

          func (situation *APISituation) UnmarshalJSON(data []byte) error {
    type Alias APISituation

    aux := &struct {
        Codes map[string]string
          Severity: Major
          Found in model/situation.go and 2 other locations - About 1 hr to fix
          model/operator.go on lines 67..85
          model/vehicles.go on lines 110..128

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 148.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if apiSituation.Description != nil {
        sanitizedDescription, err := sanitizer.Sanitize([]byte(apiSituation.Description.DefaultValue))
        if err != nil {
            apiSituation.Errors.Add("Description", fmt.Sprintf("%s: %v", e.ERROR_FORMAT, err))
        } else {
          Severity: Minor
          Found in model/situation.go and 1 other location - About 30 mins to fix
          model/situation.go on lines 512..519

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 102.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if apiSituation.Summary != nil {
        sanitizedSummary, err := sanitizer.Sanitize([]byte(apiSituation.Summary.DefaultValue))
        if err != nil {
            apiSituation.Errors.Add("Summary", fmt.Sprintf("%s: %v", e.ERROR_FORMAT, err))
        } else {
          Severity: Minor
          Found in model/situation.go and 1 other location - About 30 mins to fix
          model/situation.go on lines 521..528

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 102.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status