Sign upLogin

af83/edwig

View on GitHub
Star
model/stop_visit.go

Summary

Maintainability
D
1 day
Test Coverage

Method MemoryStopVisits.Load has a Cognitive Complexity of 35 (exceeds 20 allowed). Consider refactoring.
Open

func (manager *MemoryStopVisits) Load(referentialSlug string) error {
    var selectStopVisits []SelectStopVisit
    modelName := manager.model.Date()

    sqlQuery := fmt.Sprintf("select * from stop_visits where referential_slug = '%s' and model_name = '%s'", referentialSlug, modelName.String())
Severity: Minor
Found in model/stop_visit.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File stop_visit.go has 521 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package model

import (
    "encoding/json"
    "fmt"
Severity: Minor
Found in model/stop_visit.go - About 2 hrs to fix

    MemoryStopVisits has 22 methods (exceeds 20 allowed). Consider refactoring.
    Open

    type MemoryStopVisits struct {
    uuid.UUIDConsumer
    clock.ClockConsumer

    model Model
    Severity: Minor
    Found in model/stop_visit.go - About 2 hrs to fix

      Method MemoryStopVisits.Load has 51 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (manager *MemoryStopVisits) Load(referentialSlug string) error {
    var selectStopVisits []SelectStopVisit
    modelName := manager.model.Date()

    sqlQuery := fmt.Sprintf("select * from stop_visits where referential_slug = '%s' and model_name = '%s'", referentialSlug, modelName.String())
      Severity: Minor
      Found in model/stop_visit.go - About 1 hr to fix

        Method MemoryStopVisits.Load has 6 return statements (exceeds 4 allowed).
        Open

        func (manager *MemoryStopVisits) Load(referentialSlug string) error {
    var selectStopVisits []SelectStopVisit
    modelName := manager.model.Date()

    sqlQuery := fmt.Sprintf("select * from stop_visits where referential_slug = '%s' and model_name = '%s'", referentialSlug, modelName.String())
        Severity: Major
        Found in model/stop_visit.go - About 40 mins to fix

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

          func (manager *MemoryStopVisits) FindByStopAreaId(id StopAreaId) (stopVisits []*StopVisit) {
    manager.mutex.RLock()

    ids, _ := manager.byStopArea.Find(ModelId(id))
          Severity: Major
          Found in model/stop_visit.go and 5 other locations - About 1 hr to fix
          model/lines.go on lines 227..239
          model/stop_area.go on lines 317..329
          model/stop_area.go on lines 331..343
          model/stop_visit.go on lines 353..365
          model/vehicle_journey.go on lines 241..253

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 130.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

          func (manager *MemoryStopVisits) FindByVehicleJourneyId(id VehicleJourneyId) (stopVisits []*StopVisit) {
    manager.mutex.RLock()

    ids, _ := manager.byVehicleJourney.Find(ModelId(id))
          Severity: Major
          Found in model/stop_visit.go and 5 other locations - About 1 hr to fix
          model/lines.go on lines 227..239
          model/stop_area.go on lines 317..329
          model/stop_area.go on lines 331..343
          model/stop_visit.go on lines 415..427
          model/vehicle_journey.go on lines 241..253

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 130.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

          func (manager *MemoryStopVisits) FindByCode(code Code) (*StopVisit, bool) {
    manager.mutex.RLock()
    defer manager.mutex.RUnlock()

    id, ok := manager.byCode.Find(code)
          Severity: Major
          Found in model/stop_visit.go and 5 other locations - About 45 mins to fix
          model/lines.go on lines 241..251
          model/operator.go on lines 142..152
          model/stop_area.go on lines 279..289
          model/vehicle_journey.go on lines 229..239
          model/vehicles.go on lines 181..190

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 117.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  if sv.References.Valid && len(sv.References.String) > 0 {
            references := make(map[string]Reference)
            if err = json.Unmarshal([]byte(sv.References.String), &references); err != nil {
                return err
            }
          Severity: Major
          Found in model/stop_visit.go and 3 other locations - About 35 mins to fix
          model/lines.go on lines 357..363
          model/stop_area.go on lines 548..554
          model/vehicle_journey.go on lines 335..341

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                  if sv.Codes.Valid && len(sv.Codes.String) > 0 {
            codeMap := make(map[string]string)
            if err = json.Unmarshal([]byte(sv.Codes.String), &codeMap); err != nil {
                return err
            }
          Severity: Major
          Found in model/stop_visit.go and 4 other locations - About 35 mins to fix
          model/lines.go on lines 365..371
          model/operator.go on lines 196..203
          model/stop_area.go on lines 556..562
          model/vehicle_journey.go on lines 343..349

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 104.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

          func (manager *MemoryStopVisits) Find(id StopVisitId) (*StopVisit, bool) {
    manager.mutex.RLock()
    stopVisit, ok := manager.byIdentifier[id]
    manager.mutex.RUnlock()
          Severity: Major
          Found in model/stop_visit.go and 5 other locations - About 30 mins to fix
          model/lines.go on lines 216..225
          model/operator.go on lines 120..129
          model/stop_area.go on lines 268..277
          model/vehicle_journey.go on lines 218..227
          model/vehicles.go on lines 170..179

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 101.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status