Sign upLogin

af83/edwig

View on GitHub
Star
model/stop_visit_archiver.go

Summary

Maintainability
A
3 hrs
Test Coverage

Method StopVisitArchiver.Archive has 59 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (sva *StopVisitArchiver) Archive() {
    sv := sva.StopVisit
    sa := sva.StopArea()
    vj := sva.VehicleJourney()
    longTermStopVisitEvent := &audit.BigQueryLongTermStopVisitEvent{
Severity: Minor
Found in model/stop_visit_archiver.go - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (sva *StopVisitArchiver) setArrivalTimeEventFromKind(sv *StopVisit, kind schedules.StopVisitScheduleType) bigquery.NullTimestamp {
    t := bigquery.NullTimestamp{}
    arrivalTime := sv.Schedules.ArrivalTimeFromKind([]schedules.StopVisitScheduleType{kind})
    if arrivalTime == (time.Time{}) {
        t.Valid = false
    Severity: Major
    Found in model/stop_visit_archiver.go and 1 other location - About 1 hr to fix
    model/stop_visit_archiver.go on lines 115..126

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 136.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (sva *StopVisitArchiver) setDepartureTimeEventFromKind(sv *StopVisit, kind schedules.StopVisitScheduleType) bigquery.NullTimestamp {
    t := bigquery.NullTimestamp{}
    departureTime := sv.Schedules.DepartureTimeFromKind([]schedules.StopVisitScheduleType{kind})
    if departureTime == (time.Time{}) {
        t.Valid = false
    Severity: Major
    Found in model/stop_visit_archiver.go and 1 other location - About 1 hr to fix
    model/stop_visit_archiver.go on lines 102..113

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 136.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status