siri/siri/vehicle_monitoring_response.go

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 14 locations. Consider refactoring.
Open

func (response *SIRIVehicleActivity) BuildVehicleActivityXML() (string, error) {
    var buffer bytes.Buffer

    if err := templates.ExecuteTemplate(&buffer, "vehicle_activity.template", response); err != nil {
        logger.Log.Debugf("Error while executing template: %v", err)
Severity: Major
Found in siri/siri/vehicle_monitoring_response.go and 13 other locations - About 40 mins to fix
siri/siri/estimated_timetable_request.go on lines 58..66
siri/siri/estimated_timetable_request.go on lines 68..76
siri/siri/estimated_timetable_response.go on lines 146..153
siri/siri/estimated_timetable_response.go on lines 170..177
siri/siri/production_timetable_response.go on lines 76..84
siri/siri/situation_exchange_request.go on lines 62..69
siri/siri/situation_exchange_response.go on lines 119..126
siri/siri/situation_exchange_response.go on lines 128..135
siri/siri/situation_exchange_response.go on lines 137..144
siri/siri/vehicle_monitoring_request.go on lines 47..54
siri/siri/vehicle_monitoring_request.go on lines 56..63
siri/siri/vehicle_monitoring_response.go on lines 129..137
siri/siri/vehicle_monitoring_response.go on lines 149..157

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

func (response *SIRIMonitoredVehicleJourney) BuildMonitoredVehicleJourneyXML() (string, error) {
    var buffer bytes.Buffer

    if err := templates.ExecuteTemplate(&buffer, "monitored_vehicle_journey.template", response); err != nil {
        logger.Log.Debugf("Error while executing template: %v", err)
Severity: Major
Found in siri/siri/vehicle_monitoring_response.go and 13 other locations - About 40 mins to fix
siri/siri/estimated_timetable_request.go on lines 58..66
siri/siri/estimated_timetable_request.go on lines 68..76
siri/siri/estimated_timetable_response.go on lines 146..153
siri/siri/estimated_timetable_response.go on lines 170..177
siri/siri/production_timetable_response.go on lines 76..84
siri/siri/situation_exchange_request.go on lines 62..69
siri/siri/situation_exchange_response.go on lines 119..126
siri/siri/situation_exchange_response.go on lines 128..135
siri/siri/situation_exchange_response.go on lines 137..144
siri/siri/vehicle_monitoring_request.go on lines 47..54
siri/siri/vehicle_monitoring_request.go on lines 56..63
siri/siri/vehicle_monitoring_response.go on lines 129..137
siri/siri/vehicle_monitoring_response.go on lines 139..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 14 locations. Consider refactoring.
Open

func (response *SIRIVehicleMonitoringDelivery) BuildVehicleMonitoringDeliveryXML() (string, error) {
    var buffer bytes.Buffer

    if err := templates.ExecuteTemplate(&buffer, "vehicle_monitoring_delivery.template", response); err != nil {
        logger.Log.Debugf("Error while executing template: %v", err)
Severity: Major
Found in siri/siri/vehicle_monitoring_response.go and 13 other locations - About 40 mins to fix
siri/siri/estimated_timetable_request.go on lines 58..66
siri/siri/estimated_timetable_request.go on lines 68..76
siri/siri/estimated_timetable_response.go on lines 146..153
siri/siri/estimated_timetable_response.go on lines 170..177
siri/siri/production_timetable_response.go on lines 76..84
siri/siri/situation_exchange_request.go on lines 62..69
siri/siri/situation_exchange_response.go on lines 119..126
siri/siri/situation_exchange_response.go on lines 128..135
siri/siri/situation_exchange_response.go on lines 137..144
siri/siri/vehicle_monitoring_request.go on lines 47..54
siri/siri/vehicle_monitoring_request.go on lines 56..63
siri/siri/vehicle_monitoring_response.go on lines 139..147
siri/siri/vehicle_monitoring_response.go on lines 149..157

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status