afair/email_address

View on GitHub
lib/email_address/address.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Class Address has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Address
    include Comparable
    include Rewriter

    attr_accessor :original, :local, :host, :config, :reason, :locale
Severity: Minor
Found in lib/email_address/address.rb - About 3 hrs to fix

    Method valid? has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        def valid?(options = {})
          @error = nil
          unless local.valid?
            return set_error local.error
          end
    Severity: Minor
    Found in lib/email_address/address.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method matches? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def matches?(*rules)
          rules.flatten!
          match = local.matches?(rules)
          match ||= host.matches?(rules)
          return match if match
    Severity: Minor
    Found in lib/email_address/address.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return false unless host.valid?
    Severity: Major
    Found in lib/email_address/address.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return false unless local.valid?
      Severity: Major
      Found in lib/email_address/address.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status