lib/email_address/address.rb
Class Address
has 27 methods (exceeds 20 allowed). Consider refactoring. Open
Open
class Address
include Comparable
include Rewriter
attr_accessor :original, :local, :host, :config, :reason, :locale
Method valid?
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
Open
def valid?(options = {})
@error = nil
unless local.valid?
return set_error local.error
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method matches?
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def matches?(*rules)
rules.flatten!
match = local.matches?(rules)
match ||= host.matches?(rules)
return match if match
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
Open
return false unless host.valid?
Avoid too many return
statements within this method. Open
Open
return false unless local.valid?