Sign upLogin

afimb/chouette2

View on GitHub
Star
app/helpers/compliance_checks_helper.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method object_labels_hash has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def object_labels_hash (error)
    ### THE error HASH STRUCTURE
    # 1. error[:source]
    #      0..1 file
    #           1 filename
Severity: Minor
Found in app/helpers/compliance_checks_helper.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method object_url has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def object_url (referential_id, error)
    location = "/referentials/#{referential_id}"
    object_path = error[:source][:object_path]
    object_path.delete_at(1) if object_path.first['type'] == "vehicle_journey"
    types, identifiers = object_path.reverse.map { |resource| [ resource['type'], resource['id'] ] }.transpose
Severity: Minor
Found in app/helpers/compliance_checks_helper.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method compliance_icon has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def compliance_icon( compliance_check)
    return nil unless compliance_check.compliance_check_validation_report
    compliance_check.compliance_check_validation_report.tap do |cct|
      if cct.failed? || cct.any_error_severity_failure?
        return 'icons/link_page_alert.png'
Severity: Minor
Found in app/helpers/compliance_checks_helper.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status