afimb/chouette2

View on GitHub
app/models/export_task.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method period_validation has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

  def period_validation
    st_date = start_date.present? && start_date.is_a?(String) ? Date.parse(start_date) : start_date
    ed_date = end_date.present? && end_date.is_a?(String) ? Date.parse(end_date) : end_date

    unless  Chouette::TimeTable.start_validity_period.nil? || st_date.nil?
Severity: Minor
Found in app/models/export_task.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method init_period has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def init_period
    unless Chouette::TimeTable.start_validity_period.nil?
      if start_date.nil?
        self.start_date = Chouette::TimeTable.start_validity_period
      end
Severity: Minor
Found in app/models/export_task.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status