Sign upLogin

afimb/cvdtc

View on GitHub
Star
app/jobs/ievkit_job.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Model attribute used in file name
Open

    File.open(job_tmp_file, 'wb') do |f|
Severity: Minor
Found in app/jobs/ievkit_job.rb by brakeman

Using user input when accessing files (local or remote) will raise a warning in Brakeman.

For example

File.open("/tmp/#{cookie[:file]}")

will raise an error like

Cookie value used in file name near line 4: File.open("/tmp/#{cookie[:file]}")

This type of vulnerability can be used to access arbitrary files on a server (including /etc/passwd.

Cyclomatic complexity for perform is too high. [7/6]
Open

  def perform(*args)
    args = args.reduce
    @job = Job.find_pending(args[:id]).first
    unless @job
      retry_job(wait: 10.seconds) if Job.where(id: args[:id]).any?
Severity: Minor
Found in app/jobs/ievkit_job.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method perform has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def perform(*args)
    args = args.reduce
    @job = Job.find_pending(args[:id]).first
    unless @job
      retry_job(wait: 10.seconds) if Job.where(id: args[:id]).any?
Severity: Minor
Found in app/jobs/ievkit_job.rb - About 1 hr to fix

    Method perform has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def perform(*args)
    args = args.reduce
    @job = Job.find_pending(args[:id]).first
    unless @job
      retry_job(wait: 10.seconds) if Job.where(id: args[:id]).any?
    Severity: Minor
    Found in app/jobs/ievkit_job.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status