Sign upLogin

afimb/ievkit

View on GitHub
Star
lib/ievkit/client.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method prepare_request has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def prepare_request(url, http_method, disable_cache = false)
      unless disable_cache
        cache_key = [url, http_method.to_s].join('_')
        begin
          response_cached = @redis.cache(cache_key)
Severity: Minor
Found in lib/ievkit/client.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for prepare_request is too high. [10/6]
Open

    def prepare_request(url, http_method, disable_cache = false)
      unless disable_cache
        cache_key = [url, http_method.to_s].join('_')
        begin
          response_cached = @redis.cache(cache_key)
Severity: Minor
Found in lib/ievkit/client.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method has too many lines. [31/30]
Open

    def prepare_request(url, http_method, disable_cache = false)
      unless disable_cache
        cache_key = [url, http_method.to_s].join('_')
        begin
          response_cached = @redis.cache(cache_key)
Severity: Minor
Found in lib/ievkit/client.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method prepare_request has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def prepare_request(url, http_method, disable_cache = false)
      unless disable_cache
        cache_key = [url, http_method.to_s].join('_')
        begin
          response_cached = @redis.cache(cache_key)
Severity: Minor
Found in lib/ievkit/client.rb - About 1 hr to fix

    Method init_files has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def init_files(options)
      return unless options
      if options[:iev_params].present? && File.file?(options[:iev_params])
        @payload[:file[0]] = Faraday::UploadIO.new(options[:iev_params], 'application/json', 'parameters.json')
      end
    Severity: Minor
    Found in lib/ievkit/client.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status