Sign upLogin

agorlov/lipid

View on GitHub
Star

Showing 16 of 21 total issues

Method set has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $name,
        $value = "",
        int $expire = 0,
        string $path = "",
        string $domain = "",
Severity: Major
Found in src/Cookie.php - About 50 mins to fix

    Method set has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $name,
        $value = "",
        int $expire = 0,
        string $path = "",
        string $domain = "",
    Severity: Major
    Found in src/Cookie/CookieStd.php - About 50 mins to fix

      The method set has a boolean flag argument $secire, which is a certain sign of a Single Responsibility Principle violation.
      Open

              bool $secire = false,
      Severity: Minor
      Found in src/Cookie/CookieStd.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Missing class import via use statement (line '27', column '31').
      Open

                  $this->twig = new \Twig\Environment(
      Severity: Minor
      Found in src/Tpl/Twig.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The method set has a boolean flag argument $httponly, which is a certain sign of a Single Responsibility Principle violation.
      Open

              bool $httponly = false
      Severity: Minor
      Found in src/Cookie/CookieStd.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Missing class import via use statement (line '24', column '23').
      Open

                  throw new \Exception("Parameter '$name' not declared in config.");
      Severity: Minor
      Found in src/Config/CfgArr.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The method set has a boolean flag argument $httponly, which is a certain sign of a Single Responsibility Principle violation.
      Open

              bool $httponly = false
      Severity: Minor
      Found in src/Cookie.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Missing class import via use statement (line '34', column '23').
      Open

                  throw new \Exception("\$tplPath must be string or \Twig\Environment." . print_r($tplPath, true));
      Severity: Minor
      Found in src/Tpl/Twig.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The method set has a boolean flag argument $secire, which is a certain sign of a Single Responsibility Principle violation.
      Open

              bool $secire = false,
      Severity: Minor
      Found in src/Cookie.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Missing class import via use statement (line '28', column '21').
      Open

                      new \Twig\Loader\FilesystemLoader($tplPath),
      Severity: Minor
      Found in src/Tpl/Twig.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      exists accesses the super-global variable $_COOKIE.
      Open

          public function exists($name): bool
    {
        return array_key_exists($name, $_COOKIE);
    }
      Severity: Minor
      Found in src/Cookie/CookieStd.php by phpmd

      Superglobals

      Since: 0.2

      Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

      Example

      class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

      Source

      get accesses the super-global variable $_SESSION.
      Open

          public function get($param)
    {
        $this->sessionStart();
        return $_SESSION[$param] ?? null;
    }
      Severity: Minor
      Found in src/Session/AppSession.php by phpmd

      Superglobals

      Since: 0.2

      Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

      Example

      class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

      Source

      set accesses the super-global variable $_SESSION.
      Open

          public function set($param, $value): void
    {
        $this->sessionStart();
        $_SESSION[$param] = $value;
        session_commit();
      Severity: Minor
      Found in src/Session/AppSession.php by phpmd

      Superglobals

      Since: 0.2

      Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

      Example

      class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

      Source

      exists accesses the super-global variable $_SESSION.
      Open

          public function exists($param): bool
    {
        $this->sessionStart();
        return array_key_exists($param, $_SESSION);
    }
      Severity: Minor
      Found in src/Session/AppSession.php by phpmd

      Superglobals

      Since: 0.2

      Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

      Example

      class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

      Source

      unset accesses the super-global variable $_SESSION.
      Open

          public function unset($param): void
    {
        $this->sessionStart();
        unset($_SESSION[$param]);
        session_commit();
      Severity: Minor
      Found in src/Session/AppSession.php by phpmd

      Superglobals

      Since: 0.2

      Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

      Example

      class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

      Source

      get accesses the super-global variable $_COOKIE.
      Open

          public function get($name) : string
    {
        if ($this->exists($name)) {
            return $_COOKIE[$name];
        } else {
      Severity: Minor
      Found in src/Cookie/CookieStd.php by phpmd

      Superglobals

      Since: 0.2

      Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

      Example

      class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

      Source

      Severity
      Category
      Status
      Source
      Language