Sign upLogin

ahbeng/NUSMods

View on GitHub
Star
export/src/handler.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function makeExportHandler has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

export function makeExportHandler<T>(
  parseExportData: (request: NowRequest) => T,
  performExport: (response: NowResponse, page: Page, data: T) => void | Promise<void>,
): NowApiHandler {
  return async function handler(request, response) {
Severity: Minor
Found in export/src/handler.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function makeExportHandler has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function makeExportHandler<T>(
  parseExportData: (request: NowRequest) => T,
  performExport: (response: NowResponse, page: Page, data: T) => void | Promise<void>,
): NowApiHandler {
  return async function handler(request, response) {
Severity: Minor
Found in export/src/handler.ts - About 1 hr to fix

    Function handler has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      return async function handler(request, response) {
    try {
      throwIfAcademicYearNotSet();
      setUpSentry();
    Severity: Minor
    Found in export/src/handler.ts - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status