Sign upLogin

ahbeng/NUSMods

View on GitHub
Star
scrapers/cpex-scraper/src/index.ts

Summary

Maintainability
C
1 day
Test Coverage

Function scraper has 101 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function scraper() {
  const getDepartmentsResponse = await axios.post<ApiResponse<GetDepartmentsResponseData[]>>(
    `${baseUrl}/config/get-acadorg`,
    {
      eff_status: 'A',
Severity: Major
Found in scrapers/cpex-scraper/src/index.ts - About 4 hrs to fix

    Function scraper has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

    async function scraper() {
  const getDepartmentsResponse = await axios.post<ApiResponse<GetDepartmentsResponseData[]>>(
    `${baseUrl}/config/get-acadorg`,
    {
      eff_status: 'A',
    Severity: Minor
    Found in scrapers/cpex-scraper/src/index.ts - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

          if (
        !module.CourseTitle ||
        !module.ModularCredit ||
        !module.Subject ||
        !module.CatalogNumber ||
    Severity: Major
    Found in scrapers/cpex-scraper/src/index.ts - About 40 mins to fix

      There are no issues that match your filters.

      Category
      Status