ahbeng/NUSMods

View on GitHub
website/src/reducers/undoHistory.ts

Summary

Maintainability
A
2 hrs
Test Coverage

Function computeUndoStacks has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

export function computeUndoStacks<T extends { undoHistory: UndoHistoryState<T> }>(
  state: UndoHistoryState<T> = {
    past: [],
    present: undefined, // Don't pretend to know the present
    future: [],
Severity: Minor
Found in website/src/reducers/undoHistory.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function computeUndoStacks has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  state: UndoHistoryState<T> = {
    past: [],
    present: undefined, // Don't pretend to know the present
    future: [],
  },
Severity: Minor
Found in website/src/reducers/undoHistory.ts - About 35 mins to fix

    Avoid too many return statements within this function.
    Open

          return {
            past: [...past, present],
            present: next,
            future: newFuture,
          };
    Severity: Major
    Found in website/src/reducers/undoHistory.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return state;
      Severity: Major
      Found in website/src/reducers/undoHistory.ts - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status