Sign upLogin

ahbeng/NUSMods

View on GitHub
Star
website/src/serverless/nus-auth.ts

Summary

Maintainability
A
2 hrs
Test Coverage

Function authenticate has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const authenticate = async (req: Request) => {
  const tokenProvided = req.headers.authorization || (req.body && req.body.SAMLResponse);
  if (!tokenProvided) {
    throw new Error(errors.noTokenSupplied);
  }
Severity: Minor
Found in website/src/serverless/nus-auth.ts - About 1 hr to fix

    Function verifyLogin has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      (next: Handler): Handler =>
  async (req, res): Promise<void> => {
    try {
      const { user } = await authenticate(req);
      // TODO: Augment VercelApiHandler's request with a user object, or find
    Severity: Minor
    Found in website/src/serverless/nus-auth.ts - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function authenticate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    export const authenticate = async (req: Request) => {
  const tokenProvided = req.headers.authorization || (req.body && req.body.SAMLResponse);
  if (!tokenProvided) {
    throw new Error(errors.noTokenSupplied);
  }
    Severity: Minor
    Found in website/src/serverless/nus-auth.ts - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status