ahbeng/NUSMods

View on GitHub
website/src/views/components/icons/weather.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function getWeatherIcon has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

export default function getWeatherIcon(description: string) {
  const cleanedDesc = description.toLowerCase().replace(/[^a-z ]+/g, '');

  // Fair (Day), Fair (Night), Fair & Warm
  if (cleanedDesc.includes('fair')) {
Severity: Minor
Found in website/src/views/components/icons/weather.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return Wind;
Severity: Major
Found in website/src/views/components/icons/weather.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return Thunderstorm;
    Severity: Major
    Found in website/src/views/components/icons/weather.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return cleanedDesc.includes('light') ? Showers : Rain;
      Severity: Major
      Found in website/src/views/components/icons/weather.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

          return null;
        Severity: Major
        Found in website/src/views/components/icons/weather.ts - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status