ahbeng/NUSMods

View on GitHub
website/src/views/modules/ModulePageContent.tsx

Summary

Maintainability
C
1 day
Test Coverage

File ModulePageContent.tsx has 314 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { memo, useState } from 'react';
import classnames from 'classnames';
import ScrollSpy from 'react-scrollspy';
import { kebabCase, map, mapValues, values, sortBy } from 'lodash';

Severity: Minor
Found in website/src/views/modules/ModulePageContent.tsx - About 3 hrs to fix

    Function ModulePageContent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    const ModulePageContent: React.FC<Props> = ({ module, archiveYear }) => {
      const [isMenuOpen, setIsMenuOpen] = useState(false);
    
      const { moduleCode, title } = module;
    
    
    Severity: Minor
    Found in website/src/views/modules/ModulePageContent.tsx - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

                      {module.prerequisiteAdvisory && (
                        <>
                          <dt>Prerequisite Advisory</dt>
                          <dd>
                            <LinkModuleCodes>{module.prerequisiteAdvisory}</LinkModuleCodes>
    Severity: Major
    Found in website/src/views/modules/ModulePageContent.tsx and 6 other locations - About 1 hr to fix
    website/src/views/modules/ModuleFinderItem.tsx on lines 63..70
    website/src/views/modules/ModuleFinderItem.tsx on lines 72..79
    website/src/views/modules/ModuleFinderItem.tsx on lines 81..88
    website/src/views/modules/ModulePageContent.tsx on lines 140..147
    website/src/views/modules/ModulePageContent.tsx on lines 158..165
    website/src/views/modules/ModulePageContent.tsx on lines 167..174

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

                      {module.corequisite && (
                        <>
                          <dt>Corequisite</dt>
                          <dd>
                            <LinkModuleCodes>{module.corequisite}</LinkModuleCodes>
    Severity: Major
    Found in website/src/views/modules/ModulePageContent.tsx and 6 other locations - About 1 hr to fix
    website/src/views/modules/ModuleFinderItem.tsx on lines 63..70
    website/src/views/modules/ModuleFinderItem.tsx on lines 72..79
    website/src/views/modules/ModuleFinderItem.tsx on lines 81..88
    website/src/views/modules/ModulePageContent.tsx on lines 140..147
    website/src/views/modules/ModulePageContent.tsx on lines 149..156
    website/src/views/modules/ModulePageContent.tsx on lines 167..174

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

                      {module.preclusion && (
                        <>
                          <dt>Preclusion</dt>
                          <dd>
                            <LinkModuleCodes>{module.preclusion}</LinkModuleCodes>
    Severity: Major
    Found in website/src/views/modules/ModulePageContent.tsx and 6 other locations - About 1 hr to fix
    website/src/views/modules/ModuleFinderItem.tsx on lines 63..70
    website/src/views/modules/ModuleFinderItem.tsx on lines 72..79
    website/src/views/modules/ModuleFinderItem.tsx on lines 81..88
    website/src/views/modules/ModulePageContent.tsx on lines 140..147
    website/src/views/modules/ModulePageContent.tsx on lines 149..156
    website/src/views/modules/ModulePageContent.tsx on lines 158..165

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

                      {module.prerequisite && (
                        <>
                          <dt>Prerequisite</dt>
                          <dd>
                            <LinkModuleCodes>{module.prerequisite}</LinkModuleCodes>
    Severity: Major
    Found in website/src/views/modules/ModulePageContent.tsx and 6 other locations - About 1 hr to fix
    website/src/views/modules/ModuleFinderItem.tsx on lines 63..70
    website/src/views/modules/ModuleFinderItem.tsx on lines 72..79
    website/src/views/modules/ModuleFinderItem.tsx on lines 81..88
    website/src/views/modules/ModulePageContent.tsx on lines 149..156
    website/src/views/modules/ModulePageContent.tsx on lines 158..165
    website/src/views/modules/ModulePageContent.tsx on lines 167..174

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            <div className={classnames(styles.archiveWarning, 'alert alert-warning')}>
              <Archive className={styles.archiveIcon} />
              <p>
                This course is not offered in this academic year. You may use this information to map
                exchange courses or to see courses that were previously or may be offered in the future.
    Severity: Major
    Found in website/src/views/modules/ModulePageContent.tsx and 1 other location - About 1 hr to fix
    website/src/views/modules/ModuleFinderItem.tsx on lines 95..98

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status