Sign upLogin

ahbeng/NUSMods

View on GitHub
Star
website/src/views/planner/CustomModuleForm.tsx

Summary

Maintainability
B
4 hrs
Test Coverage

Function CustomModuleFormComponent has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const CustomModuleFormComponent: React.FC<Props> = (props) => {
  // We use an uncontrolled form here because we don't want to update the
  // module title and MCs live
  const inputModuleCredit = React.createRef<HTMLInputElement>();
  const inputTitle = React.createRef<HTMLInputElement>();
Severity: Major
Found in website/src/views/planner/CustomModuleForm.tsx - About 3 hrs to fix

    Function CustomModuleFormComponent has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    export const CustomModuleFormComponent: React.FC<Props> = (props) => {
  // We use an uncontrolled form here because we don't want to update the
  // module title and MCs live
  const inputModuleCredit = React.createRef<HTMLInputElement>();
  const inputTitle = React.createRef<HTMLInputElement>();
    Severity: Minor
    Found in website/src/views/planner/CustomModuleForm.tsx - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status