Sign upLogin

ahbeng/NUSMods

View on GitHub
Star
website/src/views/timetable/TimetableCell.tsx

Summary

Maintainability
A
3 hrs
Test Coverage

Function TimetableCell has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const TimetableCell: React.FC<Props> = (props) => {
  const { lesson, showTitle, onClick, onHover, hoverLesson, transparent } = props;

  const moduleName = showTitle ? `${lesson.moduleCode} ${lesson.title}` : lesson.moduleCode;
  const Cell = props.onClick ? 'button' : 'div';
Severity: Minor
Found in website/src/views/timetable/TimetableCell.tsx - About 1 hr to fix

    Function formatWeekRange has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function formatWeekRange(weekRange: WeekRange) {
  const start = parseISO(weekRange.start);

  // Start = end means there's just one lesson
  if (weekRange.start === weekRange.end) return format(start, lessonDateFormat);
    Severity: Minor
    Found in website/src/views/timetable/TimetableCell.tsx - About 1 hr to fix

      Function TimetableCell has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      const TimetableCell: React.FC<Props> = (props) => {
  const { lesson, showTitle, onClick, onHover, hoverLesson, transparent } = props;

  const moduleName = showTitle ? `${lesson.moduleCode} ${lesson.title}` : lesson.moduleCode;
  const Cell = props.onClick ? 'button' : 'div';
      Severity: Minor
      Found in website/src/views/timetable/TimetableCell.tsx - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status