Sign upLogin

ahmedgaafer/JS-Data-Structures

View on GitHub
Star
src/BST/index.test.ts

Summary

Maintainability
C
7 hrs
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it("should throw an error", () => {
        const tree: BST<number> = new BST<number>([]);

        expect(() => tree.getMaxNode()).toThrowError("Tree is empty");
    });
Severity: Major
Found in src/BST/index.test.ts and 4 other locations - About 1 hr to fix
src/BST/index.test.ts on lines 144..148
src/BST/index.test.ts on lines 150..154
src/BST/index.test.ts on lines 156..160
src/BST/index.test.ts on lines 162..168

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it("getMaxNode from empty tree", () => {
        const tree: BST<number> = new BST<number>([]);

        expect(() => tree.getMaxNode()).toThrowError("Tree is empty");
    });
Severity: Major
Found in src/BST/index.test.ts and 4 other locations - About 1 hr to fix
src/BST/index.test.ts on lines 38..42
src/BST/index.test.ts on lines 144..148
src/BST/index.test.ts on lines 156..160
src/BST/index.test.ts on lines 162..168

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it("getMaxDepth from empty tree", () => {
        const tree: BST<number> = new BST<number>([]);

        expect(() => tree.getMaxDepth()).toThrowError(
            "Can not get depth of an empty tree",
Severity: Major
Found in src/BST/index.test.ts and 4 other locations - About 1 hr to fix
src/BST/index.test.ts on lines 38..42
src/BST/index.test.ts on lines 144..148
src/BST/index.test.ts on lines 150..154
src/BST/index.test.ts on lines 156..160

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it("getMinNode from empty tree", () => {
        const tree: BST<number> = new BST<number>([]);

        expect(() => tree.getMinNode()).toThrowError("Tree is empty");
    });
Severity: Major
Found in src/BST/index.test.ts and 4 other locations - About 1 hr to fix
src/BST/index.test.ts on lines 38..42
src/BST/index.test.ts on lines 144..148
src/BST/index.test.ts on lines 150..154
src/BST/index.test.ts on lines 162..168

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it("view from empty tree", () => {
        const tree: BST<number> = new BST<number>([]);

        expect(() => tree.view()).toThrowError("Can not display an empty tree");
    });
Severity: Major
Found in src/BST/index.test.ts and 4 other locations - About 1 hr to fix
src/BST/index.test.ts on lines 38..42
src/BST/index.test.ts on lines 150..154
src/BST/index.test.ts on lines 156..160
src/BST/index.test.ts on lines 162..168

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status