Sign upLogin

aiao-io/aiao

View on GitHub
Star
libs/elements/src/lib/components/tree/tree.tsx

Summary

Maintainability
A
0 mins
Test Coverage

Function canDrop has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Wontfix

  @Method()
  async canDrop(dragNodeData: TreeNodeData, dropNode: TreeNode) {
    // config 守卫
    let allow = true;
    const dropNodeData = this.dataMap.get(`${dropNode.value}`);
Severity: Minor
Found in libs/elements/src/lib/components/tree/tree.tsx - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File tree.tsx has 271 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

import { isArray, sortBy } from '@aiao/util';
import {
  Component,
  ComponentInterface,
  Element,
Severity: Minor
Found in libs/elements/src/lib/components/tree/tree.tsx - About 2 hrs to fix

    Function onNodeDrop has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Wontfix

      @Listen('aiaoTreeNodeDrop')
  async onNodeDrop(_: CustomEvent<TreeNodeEvent>) {
    const { node } = _.detail;
    const dropNodeData = this.dataMap.get(`${node.value}`)!;
    const dragNodeData = this.dragNode && this.dataMap.get(`${this.dragNode.value}`);
    Severity: Major
    Found in libs/elements/src/lib/components/tree/tree.tsx - About 2 hrs to fix

      Function renderNode has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Wontfix

        private renderNode(node: TreeDataState, needId = false, allowChildConfigIds?: (string | number)[], level = 0) {
    const { children, configId, isLeaf, id, name } = node;

    if (configId && isArray(allowChildConfigIds)) {
      const allow = allowChildConfigIds.includes(configId);
      Severity: Minor
      Found in libs/elements/src/lib/components/tree/tree.tsx - About 1 hr to fix

        Function onNodeDragOver has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Wontfix

          @Listen('aiaoTreeNodeDragOver')
  onNodeDragOver(e: CustomEvent<TreeNodeEvent>) {
    const { ev, node } = e.detail;
    if (node !== this.dragNode) {
      node.dragOver = true;
        Severity: Minor
        Found in libs/elements/src/lib/components/tree/tree.tsx - About 1 hr to fix

          Function onNodeDragOver has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Wontfix

            @Listen('aiaoTreeNodeDragOver')
  onNodeDragOver(e: CustomEvent<TreeNodeEvent>) {
    const { ev, node } = e.detail;
    if (node !== this.dragNode) {
      node.dragOver = true;
          Severity: Minor
          Found in libs/elements/src/lib/components/tree/tree.tsx - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function canDrop has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Wontfix

            @Method()
  async canDrop(dragNodeData: TreeNodeData, dropNode: TreeNode) {
    // config 守卫
    let allow = true;
    const dropNodeData = this.dataMap.get(`${dropNode.value}`);
          Severity: Minor
          Found in libs/elements/src/lib/components/tree/tree.tsx - About 1 hr to fix

            Function renderNode has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Wontfix

              private renderNode(node: TreeDataState, needId = false, allowChildConfigIds?: (string | number)[], level = 0) {
    const { children, configId, isLeaf, id, name } = node;

    if (configId && isArray(allowChildConfigIds)) {
      const allow = allowChildConfigIds.includes(configId);
            Severity: Minor
            Found in libs/elements/src/lib/components/tree/tree.tsx - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Wontfix

                  } else if (dropNode.dropType === 'in') {
        const config = this.config.find(conf => conf.id === dropNodeData.configId);
        if (config && config.childConfigIds) {
          allow = config.childConfigIds.includes(`${configId}`);
        }
            Severity: Major
            Found in libs/elements/src/lib/components/tree/tree.tsx and 1 other location - About 2 hrs to fix
            libs/elements/src/lib/components/tree/tree.tsx on lines 167..172

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 82.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Wontfix

                    if (dropParentNodeData) {
          const parentConfig = this.config.find(conf => conf.id === dropParentNodeData.configId);
          if (parentConfig && parentConfig.childConfigIds) {
            allow = parentConfig.childConfigIds.includes(`${configId}`);
          }
            Severity: Major
            Found in libs/elements/src/lib/components/tree/tree.tsx and 1 other location - About 2 hrs to fix
            libs/elements/src/lib/components/tree/tree.tsx on lines 173..178

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 82.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status