aidamanna/appetype

View on GitHub

Showing 6 of 6 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    def daily_menus
      {
        monday: {
          side_dish: params[:monday_side_dish],
          omni: params[:monday_omni],
Severity: Major
Found in app/controllers/menus/create_controller.rb and 1 other location - About 1 hr to fix
app/controllers/menus/update_controller.rb on lines 25..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    def daily_menus
      {
        monday: {
          side_dish: params[:monday_side_dish],
          omni: params[:monday_omni],
Severity: Major
Found in app/controllers/menus/update_controller.rb and 1 other location - About 1 hr to fix
app/controllers/menus/create_controller.rb on lines 18..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method set_default_values has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def set_default_values
    self.state ||= 'draft'
    self.daily_menus ||= {
      monday: {
        side_dish: '',
Severity: Minor
Found in app/models/menu.rb - About 1 hr to fix

    Method daily_menus has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def daily_menus
          {
            monday: {
              side_dish: params[:monday_side_dish],
              omni: params[:monday_omni],
    Severity: Minor
    Found in app/controllers/menus/update_controller.rb - About 1 hr to fix

      Method daily_menus has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def daily_menus
            {
              monday: {
                side_dish: params[:monday_side_dish],
                omni: params[:monday_omni],
      Severity: Minor
      Found in app/controllers/menus/create_controller.rb - About 1 hr to fix

        Method call has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def call
              @menu = Menu.find(menu_id)
              raise Error::MenuStatus, 'The menu status is not draft and cannot be updated' unless @menu.draft?
              if @menu.update(daily_menus: daily_menus)
                flash[:success] = 'Menu updated.'
        Severity: Minor
        Found in app/controllers/menus/update_controller.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language