Sign upLogin

ainame/mediakit

View on GitHub
Star

Showing 9 of 9 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      class DecoderInitializer < Base
        DELIMITER_FOR_CODER = "\n ------\n".freeze
        # Encoders:
        # V..... = Video
        # A..... = Audio
Severity: Major
Found in lib/mediakit/initializers/ffmpeg.rb and 1 other location - About 4 hrs to fix
lib/mediakit/initializers/ffmpeg.rb on lines 141..194

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 166.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      class EncoderInitializer < Base
        DELIMITER_FOR_CODER = "\n ------\n".freeze
        # Encoders:
        # V..... = Video
        # A..... = Audio
Severity: Major
Found in lib/mediakit/initializers/ffmpeg.rb and 1 other location - About 4 hrs to fix
lib/mediakit/initializers/ffmpeg.rb on lines 83..135

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 166.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method create_item has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

        def create_item(line)
          match = line.match(PATTERN)
          if match
            decode = match[:decode] != '.'
            encode = match[:encode] != '.'
Severity: Minor
Found in lib/mediakit/initializers/ffmpeg.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_item has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def create_item(line)
          match = line.match(PATTERN)
          if match
            decode = match[:decode] != '.'
            encode = match[:encode] != '.'
Severity: Minor
Found in lib/mediakit/initializers/ffmpeg.rb - About 1 hr to fix

    Method create_item has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def create_item(line)
          match =  line.match(PATTERN)
          if match
            attributes = {
              name: match[:name],
    Severity: Minor
    Found in lib/mediakit/initializers/ffmpeg.rb - About 1 hr to fix

      Method create_item has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def create_item(line)
          match =  line.match(PATTERN)
          if match
            attributes = {
              name: match[:name],
      Severity: Minor
      Found in lib/mediakit/initializers/ffmpeg.rb - About 1 hr to fix

        Method setup_watchers has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def setup_watchers(stdout, stderr)
        @timer = @timeout ? TimeoutTimer.new(@timeout, Thread.current) : nil
        @out_watcher = IOWatcher.new(stdout) { |data| @timer.update if @timer; logger.info(data); }
        @err_watcher = IOWatcher.new(stderr) { |data| @timer.update if @timer; logger.info(data); }
        @loop = Coolio::Loop.new
        Severity: Minor
        Found in lib/mediakit/process/runner.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method add_option has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def add_option(option)
        return if option.nil?
        case option
        when GlobalOption
          raise(ArgumentError, 'you can give only a GlobalOption.') if @global
        Severity: Minor
        Found in lib/mediakit/ffmpeg/options.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method teardown_watchers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def teardown_watchers
        @loop.watchers.each { |w| w.detach  if w.attached? }
        @loop.stop if @loop.has_active_watchers?
      rescue RuntimeError => e
        logger.warn(e.message)
        Severity: Minor
        Found in lib/mediakit/process/runner.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language